Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #[inline] to io::Error methods #83555

Merged
merged 1 commit into from
Mar 27, 2021

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Mar 27, 2021

Fixes #82812

@m-ou-se m-ou-se added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Mar 27, 2021
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 27, 2021
@m-ou-se m-ou-se changed the title Add #[inline] to io::Error::new_const. Add #[inline] to io::Error methods Mar 27, 2021
@m-ou-se m-ou-se force-pushed the inline-io-error-new-const branch from cdbd1a2 to ee1b33c Compare March 27, 2021 11:22
@jackh726
Copy link
Member

Is #82812 not fixed by #83353? It's closed now.

@Frago9876543210
Copy link

@jackh726 it not fixed yet. This PR should close it

@jackh726
Copy link
Member

r? @jackh726
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 27, 2021

📌 Commit ee1b33c has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 27, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 27, 2021
Rollup of 8 pull requests

Successful merges:

 - rust-lang#81351 (combine: stop eagerly evaluating consts)
 - rust-lang#82525 (make unaligned_references future-incompat lint warn-by-default)
 - rust-lang#82626 (update array missing `IntoIterator` msg)
 - rust-lang#82917 (Add function core::iter::zip)
 - rust-lang#82993 (rustdoc: Use diagnostics for error when including sources)
 - rust-lang#83522 (Improve fs error open_from unix)
 - rust-lang#83548 (Always preserve `None`-delimited groups in a captured `TokenStream`)
 - rust-lang#83555 (Add #[inline] to io::Error methods)

Failed merges:

 - rust-lang#83130 (escape_ascii take 2)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7d6af67 into rust-lang:master Mar 27, 2021
@rustbot rustbot added this to the 1.53.0 milestone Mar 27, 2021
@m-ou-se m-ou-se deleted the inline-io-error-new-const branch March 28, 2021 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance degrades if stdlib function uses io::Error::new() with &'static str
7 participants