-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update backtrace to 0.3.57 #84563
Update backtrace to 0.3.57 #84563
Conversation
Adds support for symbol resolution on illumos systems.
(rust-highfive has picked a reviewer for you, use r? to override) |
|
(will combine with the resolution to #84254 to fix stack unwinding and functional backtraces on illumos systems) |
Can you say more about the newly added docs which indicate "inaccurate unwind information can lead this library to segfault" -- is any additional mitigation or whatever necessary in std to avoid problems here? I'm not quite clear if this is a case of "malformed executables -> obviously problematic" or what the situation here is in practice. |
Oh sure yeah, that's just documenting behavior since the beginning of time, nothing is new here. Unwind information that's referring to refers to This is very different from debug information which is loaded at runtime (and could mismatch the executable). The tl;dr: no change, just documenting what's always been there. This isn't an issue afaik because there's no way to feed in arbitrary unwind info. |
Ah sounds great, that pretty much matched what I had expected but the new docs surprised me a bit. Maybe worth a commit to clarify that segfaults aren't expected unless, like, your compiler has bugs in the unwind generation or so (which, seems true with or without the crate). Thanks! @bors r+ |
📌 Commit d21fb2b has been approved by |
Rollup of 5 pull requests Successful merges: - rust-lang#84132 (Ignore nonstandard lldb version strings in compiletest) - rust-lang#84521 (Reuse modules on `hermit`) - rust-lang#84563 (Update backtrace to 0.3.57) - rust-lang#84610 (Update Clippy) - rust-lang#84613 (move representability checks to rustc_ty_utils) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Adds support for symbol resolution on illumos systems.