Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update standard library for IntoIterator implementation of arrays #85930

Merged
merged 2 commits into from
Jun 6, 2021

Conversation

mominul
Copy link
Contributor

@mominul mominul commented Jun 2, 2021

This PR partially resolves issue #84513 of updating the standard library part.

I haven't found any remaining doctest examples which are using iterators over e.g. &i32 instead of just i32 in the standard library. Can anyone point me to them if there's remaining any?

Thanks!

r? @m-ou-se

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 2, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Jun 5, 2021

Thank you!

@bors r+

I haven't found any remaining doctest examples which are using iterators over e.g. &i32 instead of just i32 in the standard library. Can anyone point me to them if there's remaining any?

If I find any, I'll ping you on #84513. :)

@bors
Copy link
Contributor

bors commented Jun 5, 2021

📌 Commit 507d97b has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2021
@mominul
Copy link
Contributor Author

mominul commented Jun 5, 2021

@m-ou-se Welcome! 😊

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 5, 2021
Update standard library for IntoIterator implementation of arrays

This PR partially resolves issue rust-lang#84513 of updating the standard library part.

I haven't found any remaining doctest examples which are using iterators over e.g. &i32 instead of just i32 in the standard library. Can anyone point me to them if there's remaining any?

Thanks!

r? `@m-ou-se`
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 5, 2021
Update standard library for IntoIterator implementation of arrays

This PR partially resolves issue rust-lang#84513 of updating the standard library part.

I haven't found any remaining doctest examples which are using iterators over e.g. &i32 instead of just i32 in the standard library. Can anyone point me to them if there's remaining any?

Thanks!

r? ``@m-ou-se``
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 6, 2021
Rollup of 8 pull requests

Successful merges:

 - rust-lang#85436 (Avoid cloning cache key)
 - rust-lang#85772 (Preserve metadata w/ Solaris-like linkers.)
 - rust-lang#85920 (Tweak wasm_base target spec to indicate linker is not GNU and update linker inferring logic for wasm-ld.)
 - rust-lang#85930 (Update standard library for IntoIterator implementation of arrays )
 - rust-lang#85972 (Rustdoc html fixes)
 - rust-lang#86028 (Drop an `if let` that will always succeed)
 - rust-lang#86043 (don't clone attrs)
 - rust-lang#86047 (Don't fire `invalid_doc_attributes` on `extern crate` items)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f923f73 into rust-lang:master Jun 6, 2021
@rustbot rustbot added this to the 1.54.0 milestone Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants