Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize str::from_utf8_unchecked as const #86213

Merged
merged 1 commit into from
Jul 4, 2021
Merged

Stabilize str::from_utf8_unchecked as const #86213

merged 1 commit into from
Jul 4, 2021

Conversation

jhpratt
Copy link
Member

@jhpratt jhpratt commented Jun 11, 2021 •
edited by JohnTitor
Loading

This stabilizes unsafe fn str::from_utf8_unchecked as const pending FCP on #75196. By the time FCP finishes, the beta will have already been cut, so I've set 1.55 as the stable-since version.

(should also be +relnotes but I don't have the permission to do that)

r? @m-ou-se

Closes #75196

@rustbot rustbot added A-const-fn A-str Area: str and String C-feature-accepted Category: A feature request that has been accepted pending implementation. S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jun 11, 2021
@jhpratt jhpratt mentioned this pull request Jun 16, 2021
Closed
3 tasks
@JohnTitor JohnTitor added the relnotes Marks issues that should be documented in the release notes of the next release. label Jun 16, 2021
@jhpratt

This comment has been minimized.

Sign in to view
@rustbot rustbot removed the S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. label Jun 19, 2021
@JohnTitor
Copy link
Member

r+'ing as the FCP is done.
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 4, 2021

📌 Commit fe7487a has been approved by JohnTitor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2021
@bors
Copy link
Contributor

bors commented Jul 4, 2021

⌛ Testing commit fe7487a with merge 308fc23...

@bors
Copy link
Contributor

bors commented Jul 4, 2021

☀️ Test successful - checks-actions
Approved by: JohnTitor
Pushing 308fc23 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 4, 2021
@bors bors merged commit 308fc23 into rust-lang:master Jul 4, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 4, 2021
@jhpratt jhpratt deleted the stabilize-const-from_utf8_unchecked branch July 7, 2021 20:07
@RalfJung RalfJung added the A-const-eval Area: Constant evaluation, covers all const contexts (static, const fn, ...) label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@m-ou-se m-ou-se

Labels
A-const-eval Area: Constant evaluation, covers all const contexts (static, const fn, ...) A-str Area: str and String C-feature-accepted Category: A feature request that has been accepted pending implementation. merged-by-bors This PR was explicitly merged by bors. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.

Tracking Issue for const core::str::from_utf8_unchecked
6 participants
@jhpratt @JohnTitor @bors @RalfJung @m-ou-se @rustbot