Reduce verbosity of tracing output of RUSTC_LOG #87903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
What part is unreadable to you? The duplication when you enter and immediately enter a nested one? In longer chains it can sometimes be helpful to see which function you came from, but I get your point. We should make this configurable, as I implemented it for miri, which already had this behavior before we used WRT the wraparound, I personally would also prefer no wraparound, so 👍 from me, may get a lot of rightwards drift though. |
|
Here's a decent example of how the verbose entry is difficult to read: without: This shows a couple things:
Verbose exit, I suppose, can go either way. But it doesn't really work without the verbose entry (example below, without entry, with/without exit). I find the extra space at the end of the block helpful for mentally parsing the control flow, which you don't get with verbose entry/exit. vs without One other (big) downside of repeating spans: if you're grepping for a call and you have repeated spans you may now have multiple matches whereas before you had one. The |
|
@bors r+ |
|
@bors rollup |
|
@bors r=oli-obk |
|
📌 Commit 62b8a5e has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Aug 11, 2021
Reduce verbosity of tracing output of RUSTC_LOG The current output is really hard to read, I find, for things like trait selection. I nearly always end up removing these calls locally. r? `@oli-obk` since you originally authored this
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Aug 11, 2021
Reduce verbosity of tracing output of RUSTC_LOG The current output is really hard to read, I find, for things like trait selection. I nearly always end up removing these calls locally. r? ``@oli-obk`` since you originally authored this
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 12, 2021
Rollup of 7 pull requests Successful merges: - rust-lang#85835 (Implement Extend<(A, B)> for (Extend<A>, Extend<B>)) - rust-lang#87671 (Warn when an escaped newline skips multiple lines) - rust-lang#87878 (:arrow_up: rust-analyzer) - rust-lang#87903 (Reduce verbosity of tracing output of RUSTC_LOG) - rust-lang#87925 (Update books) - rust-lang#87928 (Update cargo) - rust-lang#87942 (set the executable bit on pre-commit.sh) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current output is really hard to read, I find, for things like trait selection. I nearly always end up removing these calls locally.
r? @oli-obk since you originally authored this