Replace std::os::glob with extra::glob, which is written in rust #8914
Conversation
|
r? |
| // except according to those terms. | ||
|
|
||
| /*! | ||
| * Support for matching file paths against Unix shell style patterns. |
There was a problem hiding this comment.
This seems like a pretty substantial module. Would you mind writing a high-level overview type comment here? Perhaps mention why we don't use the glob libc function, some basics of how this is implemented, and just an overview of what's possible.
It would also be awesome if you could include a code example or two of how to use it.
|
This looks really good! I put some various comments throughout, but I wasn't very active on the previous pull request so I'll mainly defer to those discussing it over there. Additionally though, this is a good candidate for squashing, so would you mind squashing all your commits into one? Thanks for this! |
|
If you are happy with it now then I will squash it. |
|
lgtm, thanks! |
|
I have squished all the commits, as requested. |
This is #8201 with a bunch of amendments to address the comments (and re-based).
This feature was overlooked in the original pull request (#8914). r? @alexcrichton
This is #8201 with a bunch of amendments to address the comments (and re-based).