[stable] Fix CVE-2021-42574 and prepare Rust 1.56.1 #90460
Conversation
|
(rust-highfive has picked a reviewer for you, use r? to override) |
|
rust-highfive
added
the
S-waiting-on-review
|
The fix was developed by @estebank and reviewed by @nikomatsakis out of band. @bors r=nikomatsakis p=1000 rollup=never |
|
📌 Commit 2e7743e has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 2e7743e with merge 98024ccb044eacd3c9b07abc09014a70c23dc8b7... |
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry - libSystem.dylib not linked in? |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 2e7743e with merge 0003d1a38d97b12a389bd1e5b49f9db92094ee4a... |
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
The test is for an unstable feature that doesn't affect the stable release (no_core), and it's causing CI issues for macOS.
|
Disabled the broken test, as it doesn't affect stable (it's for an unstable feature, no_core). @bors r=nikomatsakis,pietroalbini p=1000 rollup=never |
|
📌 Commit 6552f7a has been approved by |
bors
added
S-waiting-on-bors
| @@ -0,0 +1,161 @@ | |||
| use crate::{EarlyContext, EarlyLintPass, LintContext}; | |||
There was a problem hiding this comment.
Github says this file contains bidir control characters. This will break once bootstrap gets this lint, right?
There was a problem hiding this comment.
Would `#[doc = "...\u{...}..."] work to avoid directly writing the bidir control characters?
There was a problem hiding this comment.
Uh, that's a really good point, cc @estebank. Good catch!
For the stable and beta patches I'd keep it this way, mostly because this is the patch we shared under embargo with Linux distributions ahead of time and I don't want us to apply a different patch. I'll update the master PR as soon as possible.
There was a problem hiding this comment.
Ok this is a bit harder than I thought since the lint docs generator tool doesn't understand #[doc = ""]. I'll merge the PR to master without that change as I want nightly to be fixed ASAP, we'll take care of this in a future PR.
|
☀️ Test successful - checks-actions |
This PR implements new lints to mitigate the impact of CVE-2021-42574, caused by the presence of bidirectional-override Unicode codepoints in the compiled source code. See the advisory for more information about the vulnerability.
The changes in this PR will be released later today as part of Rust 1.56.1.