-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove eval_always for check_private_in_public. #91296
Conversation
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 8e5486cf56b0dc84998ad0d85b959a74a185772c with merge 3564de8025e69d9d5593f6561b78afc9146befb4... |
☀️ Try build successful - checks-actions |
Queued 3564de8025e69d9d5593f6561b78afc9146befb4 with parent 5fd3a5c, future comparison URL. |
Finished benchmarking commit (3564de8025e69d9d5593f6561b78afc9146befb4): comparison url. Summary: This change led to large relevant mixed results 🤷 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never |
8e5486c
to
764cc71
Compare
r? @Aaron1011