-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve code for rustdoc-gui tester #91584
Improve code for rustdoc-gui tester #91584
Conversation
@@ -226,7 +226,7 @@ async function main(argv) { | |||
await Promise.race(tests_queue); | |||
} | |||
} | |||
if (!no_headless && tests_queue.length > 0) { | |||
if (tests_queue.length > 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this check intentionally removed? This seems like a potential behavior change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is in theory impossible because we run them one by one when we have the --no-headless
option. But that seems like a redundant check so I just removed it. If there is a remaining test, well, it'll be run here.
@bors r+ rollup |
📌 Commit 4c1e24b has been approved by |
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#90521 (Stabilize `destructuring_assignment`) - rust-lang#91479 (Add `[T]::as_simd(_mut)`) - rust-lang#91584 (Improve code for rustdoc-gui tester) - rust-lang#91886 (core: minor `Option` doc correction) - rust-lang#91888 (Handle unordered const/ty generics for object lifetime defaults) - rust-lang#91905 (Fix source code page sidebar on mobile) - rust-lang#91906 (Removed `in_band_lifetimes` from `library\proc_macro`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Following advice given in #91391.
It nicely improves the code readability. :)
r? @jsha