Fix an ICE when lowering a float with missing exponent magnitude #91791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
jackh726
reviewed
Dec 11, 2021
apiraino
added
the
T-compiler
nagisa
reviewed
Dec 17, 2021
|
This looks good to me, but the title for the PR as well as for the commit would benefit from being more descriptive. Perhaps something like:
|
nagisa
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Simonas Kazlauskas <[email protected]>
terrarier2111
force-pushed
the
fix-float-ice
branch
from
e40133c to
0003280
Compare
Done |
nagisa
changed the title
|
@bors r+ |
|
📌 Commit 0003280 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 19, 2021
…askrgr Rollup of 4 pull requests Successful merges: - rust-lang#91791 (Fix an ICE when lowering a float with missing exponent magnitude) - rust-lang#91878 (Remove `in_band_lifetimes` from `rustc_infer`) - rust-lang#91895 (Remove `in_band_lifetimes` for `rustc_monomorphize`) - rust-lang#92029 (Explicitly set no ELF flags for .rustc section) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes: #91434