Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement StableHash for BitSet and BitMatrix via Hash #91903

Merged
merged 2 commits into from
Dec 21, 2021
Merged

Implement StableHash for BitSet and BitMatrix via Hash #91903

merged 2 commits into from
Dec 21, 2021

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Dec 14, 2021

This fixes an issue where bit sets / bit matrices the same word
content but a different domain size would receive the same hash.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 14, 2021
@rust-highfive
Copy link
Collaborator

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 14, 2021
@jackh726
Copy link
Member

Is there a specific test/issue that this fixes?

@tmiasko
Derive hash for BitSet and BitMatrix
d496cca
@tmiasko
Implement StableHash for BitSet and BitMatrix via Hash
d0281bc 
This fixes an issue where bit sets / bit matrices the same word
content but a different domain size would receive the same hash.
@tmiasko
Copy link
Contributor Author

tmiasko commented Dec 18, 2021 •
edited
Loading

Added tests that used to fail in a previous implementation.

I added test cases to the stable hasher since it strictly requires the hash to include all information that affects PartialEq comparison.

@jackh726
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 20, 2021

📌 Commit d0281bc has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2021
@matthiaskrgr
Copy link
Member

@bors rollup=never just in case..

@bors
Copy link
Contributor

bors commented Dec 20, 2021

⌛ Testing commit d0281bc with merge e64e21a81265ec2f9388dad1ace1e1833ba0904c...

@bors
Copy link
Contributor

bors commented Dec 20, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 20, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
Attempting with retry: docker build --rm -t rust-ci -f /gha/_work/rust/rust/src/ci/docker/host-aarch64/aarch64-gnu/Dockerfile /gha/_work/rust/rust/src/ci/docker
Sending build context to Docker daemon  506.4kB

Step 1/6 : FROM ubuntu:20.04
Head https://registry-1.docker.io/v2/library/ubuntu/manifests/20.04: received unexpected HTTP status: 503 Service Unavailable
Sending build context to Docker daemon  506.4kB

Step 1/6 : FROM ubuntu:20.04
Step 1/6 : FROM ubuntu:20.04
Head https://registry-1.docker.io/v2/library/ubuntu/manifests/20.04: received unexpected HTTP status: 503 Service Unavailable
Sending build context to Docker daemon  506.4kB

Step 1/6 : FROM ubuntu:20.04
Step 1/6 : FROM ubuntu:20.04
Head https://registry-1.docker.io/v2/library/ubuntu/manifests/20.04: received unexpected HTTP status: 503 Service Unavailable
Sending build context to Docker daemon  506.4kB

Step 1/6 : FROM ubuntu:20.04
Step 1/6 : FROM ubuntu:20.04
Head https://registry-1.docker.io/v2/library/ubuntu/manifests/20.04: received unexpected HTTP status: 503 Service Unavailable
Sending build context to Docker daemon  506.4kB

Step 1/6 : FROM ubuntu:20.04
Step 1/6 : FROM ubuntu:20.04
Head https://registry-1.docker.io/v2/library/ubuntu/manifests/20.04: received unexpected HTTP status: 503 Service Unavailable
##[error]Process completed with exit code 1.
Post job cleanup.

@matthiaskrgr
Copy link
Member

@bors retry docker.io 503

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2021
@bors
Copy link
Contributor

bors commented Dec 21, 2021

⌛ Testing commit d0281bc with merge 87e8639...

@bors
Copy link
Contributor

bors commented Dec 21, 2021

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 87e8639 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 21, 2021
@bors bors merged commit 87e8639 into rust-lang:master Dec 21, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 21, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (87e8639): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@tmiasko tmiasko deleted the bit-set-hash branch December 21, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jackh726 jackh726

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.59.0
Development

Successfully merging this pull request may close these issues.
8 participants
@tmiasko @rust-highfive @jackh726 @bors @matthiaskrgr @rust-log-analyzer @rust-timer @rustbot