Remove in_band_lifetimes from rustc_codegen_llvm
#91931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
21 tasks
davidtwco
approved these changes
Dec 14, 2021
|
@bors r+ |
|
📌 Commit 462bb57 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2021
…_llvm, r=davidtwco Remove `in_band_lifetimes` from `rustc_codegen_llvm` See rust-lang#91867 for more information. This one took a while. This crate has dozens of functions not associated with any type, and most of them were using in-band lifetimes for `'ll` and `'tcx`.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2021
…_llvm, r=davidtwco Remove `in_band_lifetimes` from `rustc_codegen_llvm` See rust-lang#91867 for more information. This one took a while. This crate has dozens of functions not associated with any type, and most of them were using in-band lifetimes for `'ll` and `'tcx`.
|
☔ The latest upstream changes (presumably #91945) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
See rust-lang#91867 for more information.
LegionMammal978
force-pushed
the
less-inband-codegen_llvm
branch
from
462bb57 to
4937a55
Compare
|
@bors r=davidtwco rollup=always |
|
📌 Commit 4937a55 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 18, 2021
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#91566 (Apply path remapping to DW_AT_GNU_dwo_name when producing split DWARF) - rust-lang#91926 (Remove `in_band_lifetimes` from `rustc_metadata`) - rust-lang#91931 (Remove `in_band_lifetimes` from `rustc_codegen_llvm`) - rust-lang#92024 (rustc_codegen_llvm: Give each codegen unit a unique DWARF name on all platforms, not just Apple ones.) - rust-lang#92037 (Use a const ParamEnv when in default_method_body_is_const) - rust-lang#92047 (Set `RUST_BACKTRACE=0` when running location-detail tests) - rust-lang#92050 (Add a space and 2 grave accents ) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #91867 for more information.
This one took a while. This crate has dozens of functions not associated with any type, and most of them were using in-band lifetimes for
'lland'tcx.