Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #91990

Closed
wants to merge 16 commits into from

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

not-my-profile and others added 16 commits December 11, 2021 17:10
Also replace ' with " in rustdoc template
…rop-since, r=kennytm

Fix since attribute for const_manually_drop feature

const_manually_drop was stabilized in 1.32 as mentioned in
https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1320-2019-01-17
…wiser

Remove `in_band_lifetimes` from `rustc_borrowck`

See rust-lang#91867 for more information.
…stc_symbol_mangling, r=jackh726

Remove `in_band_lifetimes` from `rustc_symbol_mangling`

Helping out with  rust-lang#91867
…riplett

Add `io::Error::other`

This PR adds a small utility constructor, `io::Error::other`, a shorthand for `io::Error::new(io::ErrorKind::Other, err)`, something I find myself writing often.

For some concrete stats, a quick search on [grep.app](https://grep.app) shows that more than half of the uses of `io::Error::new` use `ErrorKind::Other`:
```
Error::new\((?:std::)?(?:io::)?ErrorKind:: => 3,898 results
Error::new\((?:std::)?(?:io::)?ErrorKind::Other => 2,186 results
```
update stdarch

2 commits in d219ad6..0716b22
2021-12-9 23:50:37 +0000 to 2021-12-14 16:17:57 +0100
 * Fix a bunch of typos ([Fix a bunch of typos stdarch#1267](rust-lang/stdarch#1267))
 * Stabilize armv8 neon instruction set on aarch64 ([Stabilize armv8 neon instruction set on aarch64 stdarch#1266](rust-lang/stdarch#1266))

The update stabilizes armv8 neon instructions on aarch64. rust-lang#90972
…lacrum

link to pref_align_of tracking issue

If we are not going to remove this intrinsic (rust-lang#90877), I think we should at least have a place to centralize discussion around it, so here we go. Intrinsics don't have their own separate features and usually we instead use the public method for tracking it, but this one does not have such a method... so the tracking issue is just a regular link. (And then we sue it for the const part as well.)
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Dec 16, 2021
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=8

@bors
Copy link
Contributor

bors commented Dec 16, 2021

📌 Commit bc35c70 has been approved by matthiaskrgr

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 16, 2021
@bors
Copy link
Contributor

bors commented Dec 16, 2021

⌛ Testing commit bc35c70 with merge 3e7baf8c43cf3bb643be9d02e6d64177a493e149...

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-apple failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
      Memory: 14 GB
      System Firmware Version: VMW71.00V.13989454.B64.1906190538
      Apple ROM Info: [MS_VM_CERT/SHA1/27d66596a61c48dd3dc7216fd715126e33f59ae7]Welcome to the Virtual Machine
      SMC Version (system): 2.8f0
      Serial Number (system): VMjxp+uVe+4F
      Provisioning UDID: 4203018E-580F-C1B5-9525-B745CECA79EB

hw.ncpu: 3
hw.byteorder: 1234
---
 Documenting rustc_expand v0.0.0 (/Users/runner/work/rust/rust/compiler/rustc_expand)
    Checking rustc_builtin_macros v0.0.0 (/Users/runner/work/rust/rust/compiler/rustc_builtin_macros)
[RUSTC-TIMING] rustc_builtin_macros test:false 2.255
 Documenting rustc_builtin_macros v0.0.0 (/Users/runner/work/rust/rust/compiler/rustc_builtin_macros)
error: couldn't generate documentation: stream did not contain valid UTF-8
  |
  = note: failed to create or modify "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/x86_64-apple-darwin/doc/implementors/core/fmt/trait.Debug.js"
error: could not document `rustc_middle`

Caused by:
Caused by:
  process didn't exit successfully: `/Users/runner/work/rust/rust/build/bootstrap/debug/rustdoc --edition=2021 --crate-type lib --crate-name rustc_middle compiler/rustc_middle/src/lib.rs --target x86_64-apple-darwin -o /Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/x86_64-apple-darwin/doc --error-format=json --json=diagnostic-rendered-ansi -C metadata=134edae6241cd736 -L dependency=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/x86_64-apple-darwin/release/deps -L dependency=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/release/deps --extern bitflags=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/x86_64-apple-darwin/release/deps/libbitflags-5cb39ec116166e15.rmeta --extern chalk_ir=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/x86_64-apple-darwin/release/deps/libchalk_ir-edcf5fa770901add.rmeta --extern either=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/x86_64-apple-darwin/release/deps/libeither-d74b9af90d6cf54c.rmeta --extern gsgdt=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/x86_64-apple-darwin/release/deps/libgsgdt-8cdcfc999d229e5d.rmeta --extern polonius_engine=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/x86_64-apple-darwin/release/deps/libpolonius_engine-0ee7bdaeb696f77d.rmeta --extern rand=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/x86_64-apple-darwin/release/deps/librand-30565fb9a2413f4f.rmeta --extern rand_xoshiro=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/x86_64-apple-darwin/release/deps/librand_xoshiro-081200e2c833e4b0.rmeta --extern rustc_rayon=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/x86_64-apple-darwin/release/deps/librustc_rayon-f9e81c407da92784.rmeta --extern rustc_rayon_core=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/x86_64-apple-darwin/release/deps/librustc_rayon_core-b0b3c43481f443ac.rmeta --extern rustc_apfloat=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/x86_64-apple-darwin/release/deps/librustc_apfloat-f45ad9d552e7228c.rmeta --extern rustc_arena=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/x86_64-apple-darwin/release/deps/librustc_arena-83d663e260125232.rmeta --extern rustc_ast=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/x86_64-apple-darwin/release/deps/librustc_ast-994f6c6b7641a15f.rmeta --extern rustc_attr=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/x86_64-apple-darwin/release/deps/librustc_attr-29d2c3bdfdd2f8ab.rmeta --extern rustc_data_structures=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/x86_64-apple-darwin/release/deps/librustc_data_structures-708b4668e544393a.rmeta --extern rustc_errors=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/x86_64-apple-darwin/release/deps/librustc_errors-e9b7c101a3f21af9.rmeta --extern rustc_feature=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/x86_64-apple-darwin/release/deps/librustc_feature-6c32216cc05110a6.rmeta --extern rustc_graphviz=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/x86_64-apple-darwin/release/deps/librustc_graphviz-ea745b7560d666ed.rmeta --extern rustc_hir=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/x86_64-apple-darwin/release/deps/librustc_hir-db72d23786d5f177.rmeta --extern rustc_index=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/x86_64-apple-darwin/release/deps/librustc_index-a557cf78efae785c.rmeta --extern rustc_macros=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/release/deps/librustc_macros-9b3c1a947da418c2.dylib --extern rustc_query_system=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/x86_64-apple-darwin/release/deps/librustc_query_system-8e9ccfd01d7291d4.rmeta --extern rustc_serialize=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/x86_64-apple-darwin/release/deps/librustc_serialize-c654590b07468031.rmeta --extern rustc_session=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/x86_64-apple-darwin/release/deps/librustc_session-c64df424c9431de3.rmeta --extern rustc_span=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/x86_64-apple-darwin/release/deps/librustc_span-bf62acf23af712ef.rmeta --extern rustc_target=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/x86_64-apple-darwin/release/deps/librustc_target-17250d1270437ee1.rmeta --extern rustc_type_ir=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/x86_64-apple-darwin/release/deps/librustc_type_ir-1cf1de63e843747a.rmeta --extern smallvec=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/x86_64-apple-darwin/release/deps/libsmallvec-094a05fe6afa631b.rmeta --extern tracing=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2-rustc/x86_64-apple-darwin/release/deps/libtracing-a2595b0aa949bd1f.rmeta --extern-html-root-url 'bitflags=https://docs.rs/bitflags/1.2.1/' --extern-html-root-url 'chalk_ir=https://docs.rs/chalk-ir/0.55.0/' --extern-html-root-url 'either=https://docs.rs/either/1.6.0/' --extern-html-root-url 'gsgdt=https://docs.rs/gsgdt/0.1.2/' --extern-html-root-url 'polonius_engine=https://docs.rs/polonius-engine/0.13.0/' --extern-html-root-url 'rand=https://docs.rs/rand/0.8.4/' --extern-html-root-url 'rand_xoshiro=https://docs.rs/rand_xoshiro/0.6.0/' --extern-html-root-url 'rustc_rayon=https://docs.rs/rustc-rayon/0.3.1/' --extern-html-root-url 'rustc_rayon_core=https://docs.rs/rustc-rayon-core/0.3.1/' --extern-html-root-url 'smallvec=https://docs.rs/smallvec/1.7.0/' --extern-html-root-url 'tracing=https://docs.rs/tracing/0.1.28/' -Zunstable-options -Zsymbol-mangling-version=v0 -Dwarnings '-Wrustdoc::invalid_codeblock_attributes' --crate-version '1.59.0-nightly
  (3e7baf8c4
  2021-12-16)' --document-private-items '-Arustdoc::private-intra-doc-links' --enable-index-page -Zunstable-options -Znormalize-docs --show-type-layout --generate-link-to-definition --extern-html-root-url 'ena=https://docs.rs/ena/latest/'` (exit status: 1)
[RUSTC-TIMING] rustc_middle test:false 32.060
error: build failed



command did not execute successfully: "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage0/bin/cargo" "doc" "--target" "x86_64-apple-darwin" "-Zbinary-dep-depinfo" "-j" "3" "--release" "--locked" "--color" "always" "--features" "jemalloc llvm max_level_info" "--manifest-path" "/Users/runner/work/rust/rust/compiler/rustc/Cargo.toml" "-Zunstable-options" "-Zskip-rustdoc-fingerprint" "--no-deps" "-Zrustdoc-map" "-p" "rustc_ast" "-p" "rustc_feature" "-p" "rustc_arena" "-p" "rustc_query_system" "-p" "rustc_llvm" "-p" "coverage_test_macros" "-p" "rustc_mir_build" "-p" "rustc_fs_util" "-p" "rustc_mir_transform" "-p" "rustc_ast_pretty" "-p" "rustc_query_impl" "-p" "rustc_incremental" "-p" "rustc_resolve" "-p" "rustc_middle" "-p" "rustc_hir" "-p" "rustc_interface" "-p" "rustc_trait_selection" "-p" "rustc_ast_lowering" "-p" "rustc_parse" "-p" "rustc_ast_passes" "-p" "rustc_symbol_mangling" "-p" "rustc_attr" "-p" "rustc_errors" "-p" "rustc_codegen_ssa" "-p" "rustc_data_structures" "-p" "rustc_lexer" "-p" "rustc_parse_format" "-p" "rustc_typeck" "-p" "rustc_metadata" "-p" "rustc_lint" "-p" "rustc_apfloat" "-p" "rustc_passes" "-p" "rustc_const_eval" "-p" "rustc_graphviz" "-p" "rustc_ty_utils" "-p" "rustc_index" "-p" "rustc_mir_dataflow" "-p" "rustc_plugin_impl" "-p" "rustc_save_analysis" "-p" "rustc_traits" "-p" "rustc_session" "-p" "rustc_hir_pretty" "-p" "rustc_codegen_llvm" "-p" "rustc_error_codes" "-p" "rustc_monomorphize" "-p" "rustc_expand" "-p" "rustc_target" "-p" "rustc_privacy" "-p" "rustc_span" "-p" "rustc_macros" "-p" "rustc_driver" "-p" "rustc_type_ir" "-p" "rustc_borrowck" "-p" "rustc_builtin_macros" "-p" "rustc_serialize" "-p" "rustc_lint_defs" "-p" "rustc_infer"


Build completed unsuccessfully in 2:28:17

@bors
Copy link
Contributor

bors commented Dec 16, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 16, 2021
@matthiaskrgr
Copy link
Member Author

That's odd since none of the modiifed files are inside rustc_middle, but it also doesn't look like anything that would happen spuriously...?
The rustdoc PR does not look suspicious to me.

@matthiaskrgr matthiaskrgr deleted the rollup-stckmbg branch January 2, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.