-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Remove ordering traits from HirId
#92202
Conversation
Implement `Ord`, `PartialOrd` for SpanData
(rust-highfive has picked a reviewer for you, use r? to override) |
HirId
HirId
@rustbot author |
Use indexmap where necessary to maintain ordering
1e8cecd
to
f3f865e
Compare
// If that search fails, that is.. unusual. Maybe everything | ||
// is in the same SCC or something. In that case, find what | ||
// appears to be the most interesting point to report to the | ||
// user via an even more ad-hoc guess. | ||
categorized_path.sort_by(|p0, p1| p0.category.cmp(&p1.category)); | ||
debug!("best_blame_constraint: sorted_path={:#?}", categorized_path); | ||
|
||
categorized_path.remove(0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be able to replace this logic via this fixme:
rust/compiler/rustc_borrowck/src/diagnostics/region_errors.rs
Lines 401 to 402 in f3f865e
// FIXME(project-rfc-2229#48): This should store a captured_place not a hir id | |
if let ReturnConstraint::ClosureUpvar(upvar) = kind { |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1e6c01d
to
ab627aa
Compare
This comment has been minimized.
This comment has been minimized.
@rustbot author |
The job Click to see the possible cause of the failure (guessed by this bot)
|
Use
indexmap
whereHirId
s need ordering.Part of work on #90317.
(This is based on #90408. That PR should merge before this one.)