Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ordering traits from HirId #92233

Closed
wants to merge 1 commit into from

Conversation

pierwill
Copy link
Member

See #90317.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 23, 2021
@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 23, 2021
@pierwill pierwill marked this pull request as draft December 23, 2021 17:37
@pierwill
Copy link
Member Author

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 23, 2021
@pierwill

This comment was marked as outdated.

@rust-log-analyzer

This comment has been minimized.

@pierwill pierwill force-pushed the untrack-hirid-90317 branch from b294878 to 506d54b Compare December 23, 2021 18:51
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@pierwill pierwill force-pushed the untrack-hirid-90317 branch from 1082ace to 81dec4b Compare December 23, 2021 19:30
@pierwill pierwill changed the title [WIP] Remove ordering traits from HirId Remove ordering traits from HirId Dec 23, 2021
@pierwill
Copy link
Member Author

r? @cjgillot

@pierwill pierwill marked this pull request as ready for review December 23, 2021 19:31
@pierwill
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 23, 2021
@rust-log-analyzer

This comment has been minimized.

@cjgillot cjgillot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 26, 2021
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@pierwill pierwill force-pushed the untrack-hirid-90317 branch from a6c0192 to 7c7eb5d Compare February 15, 2022 17:58
@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Feb 18, 2022

☔ The latest upstream changes (presumably #94121) made this pull request unmergeable. Please resolve the merge conflicts.

@pierwill pierwill force-pushed the untrack-hirid-90317 branch from 7c7eb5d to 7747530 Compare February 22, 2022 21:12
@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Apr 3, 2022

☔ The latest upstream changes (presumably #85321) made this pull request unmergeable. Please resolve the merge conflicts.

@bjorn3 bjorn3 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Apr 3, 2022
@pierwill pierwill force-pushed the untrack-hirid-90317 branch from 7747530 to 491edf3 Compare April 4, 2022 17:19
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@pierwill pierwill requested a review from cjgillot April 5, 2022 00:38
@rust-log-analyzer

This comment has been minimized.

@pierwill pierwill force-pushed the untrack-hirid-90317 branch from a043bed to b05c0b5 Compare April 11, 2022 20:17
@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Apr 20, 2022

☔ The latest upstream changes (presumably #96082) made this pull request unmergeable. Please resolve the merge conflicts.

@Dylan-DPC
Copy link
Member

@pierwill can you address the CI failure? thanks

Rm Ord from LintExpectationId

Edit ToStableHashKey impl

Impl Partialord for Level using discriminant
@pierwill pierwill force-pushed the untrack-hirid-90317 branch from b05c0b5 to 076fc29 Compare July 6, 2022 18:03
@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
    Checking rustc_ast_pretty v0.0.0 (/checkout/compiler/rustc_ast_pretty)
    Checking rustc_hir v0.0.0 (/checkout/compiler/rustc_hir)
    Checking rustc_lint_defs v0.0.0 (/checkout/compiler/rustc_lint_defs)
    Checking rustc_hir_pretty v0.0.0 (/checkout/compiler/rustc_hir_pretty)
error[E0433]: failed to resolve: could not find `impl_stable_hash_via_hash` in `rustc_data_structures`
    |
    |
198 | rustc_data_structures::impl_stable_hash_via_hash!(Level);
    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^ could not find `impl_stable_hash_via_hash` in `rustc_data_structures`
error: unused import: `rustc_hir::HashStableContext`
  --> compiler/rustc_lint_defs/src/lib.rs:13:5
   |
13 | use rustc_hir::HashStableContext;
13 | use rustc_hir::HashStableContext;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `-D unused-imports` implied by `-D warnings`

error[E0599]: `std::mem::Discriminant<Level>` is not an iterator
     |
     |
194  |         std::mem::discriminant(self).partial_cmp(std::mem::discriminant(other))
     |                                      ^^^^^^^^^^^ `std::mem::Discriminant<Level>` is not an iterator
    ::: /checkout/library/core/src/mem/mod.rs:1060:1
     |
     |
1060 | pub struct Discriminant<T>(<T as DiscriminantKind>::Discriminant);
     | ------------------------------------------------------------------ doesn't satisfy `std::mem::Discriminant<Level>: Iterator`
     = note: the following trait bounds were not satisfied:
     = note: the following trait bounds were not satisfied:
             `std::mem::Discriminant<Level>: Iterator`
             which is required by `&mut std::mem::Discriminant<Level>: Iterator`
Some errors have detailed explanations: E0433, E0599.
For more information about an error, try `rustc --explain E0433`.
error: could not compile `rustc_lint_defs` due to 3 previous errors
warning: build failed, waiting for other jobs to finish...

@pierwill pierwill marked this pull request as draft July 8, 2022 03:51
@bors
Copy link
Contributor

bors commented Sep 12, 2022

☔ The latest upstream changes (presumably #99334) made this pull request unmergeable. Please resolve the merge conflicts.

@Dylan-DPC
Copy link
Member

Closing this as inactive. Feel free to reöpen or preferably create a new pull request

@Dylan-DPC Dylan-DPC closed this Dec 17, 2022
@Dylan-DPC Dylan-DPC added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.