Rollup of 9 pull requests #92907
Closed
Rollup of 9 pull requests #92907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…didates instead of param_env candidates
Also ignore clippy's "collapsible if..." lints.
(to de-duplicate my identities in the contributors list)
These reference names were very general, and used in other places.
Prefer projection candidates instead of param_env candidates for Sized predicates Fixes rust-lang#89352 Also includes some drive by logging and verbose printing changes that I found useful when debugging this, but I can remove this if needed. This is a little hacky - but imo no more than the rest of `candidate_should_be_dropped_in_favor_of`. Importantly, in a Chalk-like world, both candidates should be completely compatible. r? ``@nikomatsakis``
Extend const_convert to rest of blanket core::convert impls This adds constness to all the blanket impls in `core::convert` under the existing `const_convert` feature, tracked by rust-lang#88674. Existing impls under that feature: ```rust impl<T> const From<T> for T; impl<T, U> const Into<U> for T where U: ~const From<T>; impl<T> const ops::Try for Option<T>; impl<T> const ops::FromResidual for Option<T>; impl<T, E> const ops::Try for Result<T, E>; impl<T, E, F> const ops::FromResidual<Result<convert::Infallible, E>> for Result<T, F> where F: ~const From<E>; ``` Additional impls: ```rust impl<T: ?Sized, U: ?Sized> const AsRef<U> for &T where T: ~const AsRef<U>; impl<T: ?Sized, U: ?Sized> const AsRef<U> for &mut T where T: ~const AsRef<U>; impl<T: ?Sized, U: ?Sized> const AsMut<U> for &mut T where T: ~const AsMut<U>; impl<T, U> const TryInto<U> for T where U: ~const TryFrom<T>; impl<T, U> const TryFrom<U> for T where U: ~const Into<T>; ```
improve `_` constants in item signature handling removing the "type" from the error messages does slightly worsen the error messages for types, but figuring out whether the placeholder is for a type or a constant and correctly dealing with that seemed fairly difficult to me so I took the easy way out ✨ Imo the error message is still clear enough. r? `@BoxyUwU` cc `@estebank`
Export `tcp::IntoIncoming` Added in rust-lang#88339 but not publicly exported.
Use pre-interned symbols in a couple of places Re-open of rust-lang#92733 as bors glitched.
…-Simulacrum Clean up some links in RELEASES This fixes some issues with markdown links in the RELEASES file.
librustdoc: Address some clippy lints
…f, r=lcnr Make `opt_const_param_of` work in the presence of `GenericArg::Infer` highly recommend viewing the first and second commits on their own rather than looking at file changes 🤣 Because we filtered args down to just const args we would ignore `GenericArg::Infer` which made us get a `arg_index` which was wrong by however many const `GenericArg::Infer` came previously [example](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=46dba6a53aca6333028a10908ef16e0b) of the [bugs](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=a8eebced26eefa4119fc2e7ae0c76de6) fixed. r? ``@lcnr``
…mulacrum Add myself to .mailmap (to de-duplicate my identities in the contributors list)
rustbot
added
the
T-compiler
rustbot
added
T-rustdoc
|
@bors r+ rollup=never p=9 |
|
📌 Commit fedc8aa has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit fedc8aa with merge 8d8dd1fec0179da7eaf66927d26619ac4cc282d8... |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
_constants in item signature handling #92582 (improve_constants in item signature handling)tcp::IntoIncoming#92684 (Exporttcp::IntoIncoming)opt_const_param_ofwork in the presence ofGenericArg::Infer#92875 (Makeopt_const_param_ofwork in the presence ofGenericArg::Infer)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup