Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dot separator when there is no source link #93299

Merged
merged 2 commits into from
Jan 29, 2022
Merged

Fix dot separator when there is no source link #93299

merged 2 commits into from
Jan 29, 2022

Conversation

GuillaumeGomez
Copy link
Member

Fixes #92973.

We did well adding this test since there was a bug:

Screenshot from 2022-01-25 17-05-48

r? @jsha

@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Jan 25, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 25, 2022
@jsha
Copy link
Contributor

jsha commented Jan 29, 2022

@bors r+ rollup

Thanks!

@bors
Copy link
Contributor

bors commented Jan 29, 2022

📌 Commit 066fcb6 has been approved by jsha

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 29, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 29, 2022
@bors
Auto merge of rust-lang#93457 - matthiaskrgr:rollup-e43ry1l, r=matthi…
a00e130 
…askrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#88205 (Add Explanation For Error E0772)
 - rust-lang#92274 (Add `intrinsics::const_deallocate`)
 - rust-lang#93236 (Make `NonNull::new` `const`)
 - rust-lang#93299 (Fix dot separator when there is no source link)
 - rust-lang#93410 (kmc-solid: Implement `net::FileDesc::duplicate`)
 - rust-lang#93424 (fix nit)
 - rust-lang#93431 (remove unused `jemallocator` crate)
 - rust-lang#93453 (Add GUI theme change test)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f5f2d44 into rust-lang:master Jan 29, 2022
@rustbot rustbot added this to the 1.60.0 milestone Jan 29, 2022
@GuillaumeGomez GuillaumeGomez deleted the dot-separator-no-source branch January 29, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jsha jsha

Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.60.0
Development

Successfully merging this pull request may close these issues.

Add "dot separator" test in case there is no source link
5 participants
@GuillaumeGomez @jsha @bors @rust-highfive @rustbot