Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move utils from const_eval to mir_transform #93502

Closed
wants to merge 1 commit into from
Closed

Move utils from const_eval to mir_transform #93502

wants to merge 1 commit into from

Conversation

lilasta
Copy link
Contributor

@lilasta lilasta commented Jan 31, 2022

Since most of these are only used in mir_transform.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 31, 2022
@rust-highfive
Copy link
Collaborator

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 31, 2022
@bors
Copy link
Contributor

bors commented Feb 13, 2022

☔ The latest upstream changes (presumably #93956) made this pull request unmergeable. Please resolve the merge conflicts.

@lcnr
Copy link
Contributor

lcnr commented Feb 14, 2022

these functions don't really fit into any crate 😅 i guess moving them to transform is fine

r=me after the rebase

@lilasta
Copy link
Contributor Author

lilasta commented Feb 14, 2022

The latest changes made it difficult to move them cleanly, so I'll close this, sorry...

@lilasta lilasta closed this Feb 14, 2022
@lilasta lilasta deleted the move_files branch March 6, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants