Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use fold_list in try_super_fold_with for SubstsRef #93643

Merged
merged 1 commit into from
Feb 7, 2022
Merged

use fold_list in try_super_fold_with for SubstsRef #93643

merged 1 commit into from
Feb 7, 2022

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Feb 4, 2022 •
edited
Loading

split out from #93505 as this by itself is responsible for most of the perf improvements there

r? @michaelwoerister

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 4, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 4, 2022
@lcnr
Copy link
Contributor Author

lcnr commented Feb 4, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 4, 2022
@bors
Copy link
Contributor

bors commented Feb 4, 2022

⌛ Trying commit 711e736 with merge c892b04cd5f8abc1f132abbd4a14189de449a421...

@bors
Copy link
Contributor

bors commented Feb 4, 2022

☀️ Try build successful - checks-actions
Build commit: c892b04cd5f8abc1f132abbd4a14189de449a421 (c892b04cd5f8abc1f132abbd4a14189de449a421)

@rust-timer
Copy link
Collaborator

Queued c892b04cd5f8abc1f132abbd4a14189de449a421 with parent 4e8fb74, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c892b04cd5f8abc1f132abbd4a14189de449a421): comparison url.

Summary: This benchmark run shows 55 relevant improvements 🎉 to instruction counts.

  • Average relevant improvement: -1.0%
  • Largest improvement in instruction counts: -2.7% on full builds of keccak check

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 4, 2022
@lcnr lcnr changed the title fold substs use fold_list in try_super_fold_with for SubstsRef Feb 4, 2022
@lcnr
Copy link
Contributor Author

lcnr commented Feb 4, 2022

@michaelwoerister it probably makes sense to merge this PR by itself as without this change, #93505 is actually a regression in some cases and I don't want to hide that. Will look a bit more into #93505 separately

@lcnr lcnr marked this pull request as ready for review February 4, 2022 15:32
@michaelwoerister
Copy link
Member

The change looks good to me. Great find, @lcnr!

@bors r+

@bors
Copy link
Contributor

bors commented Feb 4, 2022

📌 Commit 711e736 has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2022
@bors
Copy link
Contributor

bors commented Feb 7, 2022

⌛ Testing commit 711e736 with merge 926e784...

@bors
Copy link
Contributor

bors commented Feb 7, 2022

☀️ Test successful - checks-actions
Approved by: michaelwoerister
Pushing 926e784 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 7, 2022
@bors bors merged commit 926e784 into rust-lang:master Feb 7, 2022
@rustbot rustbot added this to the 1.60.0 milestone Feb 7, 2022
@lcnr lcnr deleted the fold-substs-perf branch February 7, 2022 06:44
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (926e784): comparison url.

Summary: This benchmark run shows 56 relevant improvements 🎉 to instruction counts.

  • Average relevant improvement: -1.1%
  • Largest improvement in instruction counts: -2.7% on full builds of keccak check

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.60.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lcnr @rust-timer @bors @michaelwoerister @rust-highfive @rustbot