Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: remove support for multi-query search #93852

Merged
merged 1 commit into from
Feb 11, 2022
Merged

rustdoc: remove support for multi-query search #93852

merged 1 commit into from
Feb 11, 2022

Conversation

GuillaumeGomez
Copy link
Member

This is needed by #90630 to make feature changes non-existent.

cc @camelid
r? @jsha

@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-search Area: Rustdoc's search feature A-rustdoc-js Area: Rustdoc's JS front-end labels Feb 10, 2022
@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez,@Folyd,@jsha

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 10, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@petrochenkov
Copy link
Contributor

@GuillaumeGomez
Meta: could you mark PR names with the code are that they touch, like "rustdoc: Remove support for multi-query search"? (*)
Right now from the title it may look like the PR has something to do with the compiler's query system.

(*) On PR creation, not later, later changes do now show up in email clients that manage email chains.

@GuillaumeGomez
Copy link
Member Author

There is the t-rustdoc tag for that.

@GuillaumeGomez
Copy link
Member Author

Ok, I didn't forget to remove a function this time. \o/

@petrochenkov
Copy link
Contributor

@GuillaumeGomez

There is the t-rustdoc tag for that.

T-team labels may be useful for something, but certainly not for that.
They are not shown anywhere, not in the mail sent by GitHub, not even in the GitHub's own native notification interface.

@GuillaumeGomez
Copy link
Member Author

Oh I see, that's a good point. I'll try to not forget next time then.

@jsha jsha changed the title Remove support for multi-query search rustdoc: remove support for multi-query search Feb 11, 2022
@jsha
Copy link
Contributor

jsha commented Feb 11, 2022

Looks great! I like how much code this cleans up.

I went ahead and change the PR title to include rustdoc:. I know it won't affect threads in people's inboxes, but if our goal is to consistently preface Rustdoc PRs with rustdoc:, it's still useful.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 11, 2022

📌 Commit 8e12b4e has been approved by jsha

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 11, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 11, 2022
@bors
Auto merge of rust-lang#93891 - matthiaskrgr:rollup-xadut8w, r=matthi…
78450d2 
…askrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#92242 (Erase regions before calculating layout for packed field capture)
 - rust-lang#93443 (Add comment on stable_hash_impl for OwnerNodes)
 - rust-lang#93742 (Drop rustc-docs from complete profile)
 - rust-lang#93852 (rustdoc: remove support for multi-query search)
 - rust-lang#93853 (Make all `hir::Map` methods consistently by-value)
 - rust-lang#93861 (Fix ICE if no trait assoc const eq)
 - rust-lang#93862 (Split x86_64-apple builder into two)
 - rust-lang#93864 (Remove ArchiveBuilder::update_symbols)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b97cceb into rust-lang:master Feb 11, 2022
@rustbot rustbot added this to the 1.60.0 milestone Feb 11, 2022
@GuillaumeGomez GuillaumeGomez deleted the remove-multi-query branch February 11, 2022 18:47
@camelid
Copy link
Member

camelid commented Feb 11, 2022

I went ahead and change the PR title to include rustdoc:. I know it won't affect threads in people's inboxes, but if our goal is to consistently preface Rustdoc PRs with rustdoc:, it's still useful.

FWIW, in general I think we only need to prefix PR titles when it's not clear from context. E.g., if the PR title is "Fix intra-doc links bug", there's no need for a "rustdoc:" prefix.

@notriddle notriddle mentioned this pull request Mar 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jsha jsha

Labels
A-rustdoc-js Area: Rustdoc's JS front-end A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.60.0
Development

Successfully merging this pull request may close these issues.
8 participants
@GuillaumeGomez @rust-highfive @rust-log-analyzer @petrochenkov @jsha @bors @camelid @rustbot