Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename region_should_not_be_omitted to should_print_region #94280

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Feb 23, 2022

to avoid double negation

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 23, 2022
@rust-highfive
Copy link
Collaborator

Some changes occured to the CTFE / Miri engine

cc @rust-lang/miri

@rust-highfive
Copy link
Collaborator

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 23, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Feb 23, 2022

r? @oli-obk

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 23, 2022

📌 Commit 1113cd5 has been approved by oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned lcnr Feb 23, 2022
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 23, 2022
…askrgr

Rollup of 12 pull requests

Successful merges:

 - rust-lang#94128 (rustdoc: several minor fixes)
 - rust-lang#94137 (rustdoc-json: Better Header Type)
 - rust-lang#94213 (fix names in feature(...) suggestion)
 - rust-lang#94240 (Suggest calling .display() on `PathBuf` too)
 - rust-lang#94253 (Use 2021 edition in ./x.py fmt)
 - rust-lang#94259 (Bump download-ci-llvm-stamp for llvm-nm inclusion)
 - rust-lang#94260 (Fix rustdoc infinite redirection generation)
 - rust-lang#94263 (Typo fix: Close inline-code backtick)
 - rust-lang#94264 (Fix typo.)
 - rust-lang#94271 (Miri: extend comments on downcast operation)
 - rust-lang#94280 (Rename `region_should_not_be_omitted` to `should_print_region`)
 - rust-lang#94285 (Sync rustc_codegen_cranelift)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ecf2faa into rust-lang:master Feb 23, 2022
@rustbot rustbot added this to the 1.61.0 milestone Feb 23, 2022
@tmiasko tmiasko deleted the should-print-region branch February 23, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants