Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 7 pull requests #94431

Merged
merged 15 commits into from
Feb 28, 2022
Merged

Rollup of 7 pull requests #94431

merged 15 commits into from
Feb 28, 2022

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

xFrednet and others added 15 commits February 26, 2022 11:36
@xFrednet
Document that pre-expansion lint passes are deprecated
2bf56b9
@c410-f3r
Make more use of let_chains
ca2ad69
@GuillaumeGomez
Add test for rust-lang#79465 to prevent regression
915740c
@RalfJung
avoid rebuilding bootstrap when PATH changes
35e3aaf
@bjorn3
Use the first codegen backend in the config.toml as default
7ad4297 
It is currently hard coded to llvm if enabled and cranelift otherwise.
This made some sense when cranelift was the only alternative codegen
backend. Since the introduction of the gcc backend this doesn't make
much sense anymore. Before this PR bootstrapping rustc using a backend
other than llvm or cranelift required changing the source of
rustc_interface. With this PR it becomes a matter of putting the right
backend as first enabled backend in config.toml.
@GuillaumeGomez
Correctly generate links in the sidebar for impls
7e0a2a7
@GuillaumeGomez
Add test to ensure that links to impls are correctly generated
9b8a6b9
@c410-f3r
3 - Make more use of let_chains
0eb8b32 
Continuation of rust-lang#94376.

cc rust-lang#53667
@matthiaskrgr
Rollup merge of rust-lang#94396 - c410-f3r:yet-more-let-chains, r=Dyl…
8cdafbf 
…an-DPC

1 - Make more use of `let_chains`

Continuation of rust-lang#94376.

cc rust-lang#53667
@matthiaskrgr
Rollup merge of rust-lang#94397 - xFrednet:69838-deprecate-pre-expans…
9373d8b 
…ion, r=cjgillot

Document that pre-expansion lint passes are softly deprecated

The pre-expansion lint pass has been softly deprecated since rust-lang#69838. Every once in a while I see someone mention it as a possibility, only get the feedback that it's deprecated. This PR officially documents that the method is soft deprecated to have a single point of truth for it.

That's it. Have a great rest of the day 🙃

---

* See [rust#69838](rust-lang#69838)
* See [rust-clippy#5518](rust-lang/rust-clippy#5518)
@matthiaskrgr
Rollup merge of rust-lang#94399 - GuillaumeGomez:regression-test-7946…
19958c2 
…5, r=matthiaskrgr

Add test for rust-lang#79465 to prevent regression

Fixes rust-lang#79465.

Like this we will be able to close the issue.

r? ````@matthiaskrgr````
@matthiaskrgr
Rollup merge of rust-lang#94409 - RalfJung:path, r=Mark-Simulacrum
736dae2 
avoid rebuilding bootstrap when PATH changes

Fixes rust-lang#94408

r? ```@Mark-Simulacrum```
@matthiaskrgr
Rollup merge of rust-lang#94415 - bjorn3:cfg_default_backend, r=Mark-…
c930884 
…Simulacrum

Use the first codegen backend in the config.toml as default

It is currently hard coded to llvm if enabled and cranelift otherwise.
This made some sense when cranelift was the only alternative codegen
backend. Since the introduction of the gcc backend this doesn't make
much sense anymore. Before this PR bootstrapping rustc using a backend
other than llvm or cranelift required changing the source of
rustc_interface. With this PR it becomes a matter of putting the right
backend as first enabled backend in config.toml.

cc ```@antoyo```
@matthiaskrgr
Rollup merge of rust-lang#94417 - GuillaumeGomez:fix-duplicated-impl-…
04ecf52 
…links, r=notriddle

Fix duplicated impl links

Fixes rust-lang#78701.

The problem is that the blanket impl has the same ID as the other impl, except that we don't derive IDs when we generate the sidebar. We now do.

r? ``@notriddle``
@matthiaskrgr
Rollup merge of rust-lang#94420 - c410-f3r:more-let-chains, r=Dylan-DPC
5570b1d 
3 - Make more use of `let_chains`

Continuation of rust-lang#94376.

cc rust-lang#53667
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Feb 27, 2022
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=7

@bors
Copy link
Contributor

bors commented Feb 27, 2022

📌 Commit 5570b1d has been approved by matthiaskrgr

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 27, 2022
@bors
Copy link
Contributor

bors commented Feb 27, 2022

⌛ Testing commit 5570b1d with merge 238aa5f6e1eadca52671b7e4a2e12035df23b6be...

@bors
Copy link
Contributor

bors commented Feb 27, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 27, 2022
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@matthiaskrgr
Copy link
Member Author

@bors retry
auto (x86_64-msvc-1, --build=x86_64-pc-windows-msvc --enable-profiler, make ci-subset-1, windows-...
The hosted runner: GitHub Actions 58 lost communication with the server. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2022
@bors
Copy link
Contributor

bors commented Feb 28, 2022

⌛ Testing commit 5570b1d with merge 7662a8f8f32b78e21867ad1092b858dacb6bd367...

@rust-log-analyzer
Copy link
Collaborator

The job dist-i686-mingw failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Feb 28, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 28, 2022
@matthiaskrgr
Copy link
Member Author

@bors retry one more retry...

auto (dist-i686-mingw, --build=i686-pc-windows-gnu --enable-full-tools --enable-profiler, python ...
The hosted runner: GitHub Actions 15 lost communication with the server. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 28, 2022
@bors
Copy link
Contributor

bors commented Feb 28, 2022

⌛ Testing commit 5570b1d with merge b07d59f...

@bors
Copy link
Contributor

bors commented Feb 28, 2022

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing b07d59f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 28, 2022
@bors bors merged commit b07d59f into rust-lang:master Feb 28, 2022
@rustbot rustbot added this to the 1.61.0 milestone Feb 28, 2022
@bors bors mentioned this pull request Feb 28, 2022
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b07d59f): comparison url.

Summary: This benchmark run shows 4 relevant regressions 😿 to instruction counts.

  • Arithmetic mean of relevant regressions: 0.8%
  • Largest regression in instruction counts: 0.9% on incr-unchanged builds of externs opt

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

@rustbot rustbot added the perf-regression Performance regression. label Feb 28, 2022
@Mark-Simulacrum
Copy link
Member

Dropping the regression label -- externs is currently a little noisy (and we haven't absorbed that noisiness into our statistical estimation yet). Seems to be due to #93839, which makes me suspect this is related to PGO or inlining decisions of some kind. #94373 might help.

@Mark-Simulacrum Mark-Simulacrum removed the perf-regression Performance regression. label Mar 1, 2022
@matthiaskrgr matthiaskrgr deleted the rollup-1jsj0wu branch March 11, 2022 15:31
@compiler-errors compiler-errors mentioned this pull request Nov 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.