Document new recommended use of FromIterator::from_iter
#94587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @scottmcm (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Are you sure the example need to be on |
|
|
scottmcm
requested changes
Mar 4, 2022
scottmcm
added
S-waiting-on-author
|
@rustbot ready Let me know if there are still tweaks you see to improve this. I think the explicitness of mentioning the turbofish is better than referring broadly to type inference. |
rustbot
added
S-waiting-on-review
scottmcm
approved these changes
Mar 10, 2022
|
Thanks! I like this new phrasing. @bors r+ rollup |
|
📌 Commit b363f13 has been approved by |
bors
added
S-waiting-on-bors
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Mar 10, 2022
…ottmcm Document new recommended use of `FromIterator::from_iter` rust-lang#90107 Most of the added prose was paraphrased from the links provided in the issue. The suggested `VecDeque` example seemed to make the point well enough so I just used that.
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 10, 2022
…ottmcm Document new recommended use of `FromIterator::from_iter` rust-lang#90107 Most of the added prose was paraphrased from the links provided in the issue. The suggested `VecDeque` example seemed to make the point well enough so I just used that.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 10, 2022
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#94440 (Better error for normalization errors from parent crates that use `#![feature(generic_const_exprs)]`) - rust-lang#94587 (Document new recommended use of `FromIterator::from_iter`) - rust-lang#94644 (Fix soundness issue in scoped threads.) - rust-lang#94740 (Unify impl blocks by wrapping them into a div) - rust-lang#94753 (Improve rustdoc book) - rust-lang#94796 (Allow `cargo run` instead of `cargo run -p bootstrap`) - rust-lang#94805 (Revert accidental stabilization) - rust-lang#94809 (RustWrapper: add missing include) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
Congrats on your first PR landing, @JKAnderson409 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#90107
Most of the added prose was paraphrased from the links provided in the issue. The suggested
VecDequeexample seemed to make the point well enough so I just used that.