Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode even more metadata through tables instead of EntryKind #94883

Merged
merged 4 commits into from
Apr 1, 2022
Merged

Encode even more metadata through tables instead of EntryKind #94883

merged 4 commits into from
Apr 1, 2022

Conversation

cjgillot
Copy link
Contributor

This should move us closer to getting rid of EntryKind.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 12, 2022
@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 12, 2022
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 12, 2022
@bors
Copy link
Contributor

bors commented Mar 12, 2022

⌛ Trying commit 124a831e3dae8f95bb0d380dc5b4cf19e1c2b953 with merge 38f0a98fa5e7091be82d53b7ad7984c9eed5b679...

@bors
Copy link
Contributor

bors commented Mar 12, 2022

☀️ Try build successful - checks-actions
Build commit: 38f0a98fa5e7091be82d53b7ad7984c9eed5b679 (38f0a98fa5e7091be82d53b7ad7984c9eed5b679)

@rust-timer
Copy link
Collaborator

Queued 38f0a98fa5e7091be82d53b7ad7984c9eed5b679 with parent f8a29bd, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (38f0a98fa5e7091be82d53b7ad7984c9eed5b679): comparison url.

Summary: This benchmark run did not return any relevant results. 1 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 12, 2022
@bors
Copy link
Contributor

bors commented Mar 30, 2022

☔ The latest upstream changes (presumably #94963) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk
Copy link
Contributor

oli-obk commented Mar 30, 2022

sorry this slipped through my review queue...

r=me after a rebase.

@cjgillot
Copy link
Contributor Author

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Mar 30, 2022

📌 Commit 13294b335e34a95c15c7b352a2ae357b7abac3c5 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2022
@bors
Copy link
Contributor

bors commented Mar 30, 2022

⌛ Testing commit 13294b335e34a95c15c7b352a2ae357b7abac3c5 with merge 58c5362ac096969282bd3af8564122183f179a41...

@bors
Copy link
Contributor

bors commented Mar 30, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 30, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Mar 31, 2022

☔ The latest upstream changes (presumably #95436) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk
Copy link
Contributor

oli-obk commented Mar 31, 2022

@bors retry could not resolve host

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 31, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Mar 31, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Mar 31, 2022

📌 Commit 15b2d1a has been approved by oli-obk

@bors
Copy link
Contributor

bors commented Mar 31, 2022

⌛ Testing commit 15b2d1a with merge 6f56546f5c42f74ff96aa48dc525b529b6a6a583...

@bors
Copy link
Contributor

bors commented Apr 1, 2022

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 1, 2022
@cjgillot
Copy link
Contributor Author

cjgillot commented Apr 1, 2022

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2022
@bors
Copy link
Contributor

bors commented Apr 1, 2022

⌛ Testing commit 15b2d1a with merge be494154138fb8ee7d0efbe1eedfbb8ceecde9e4...

@bors
Copy link
Contributor

bors commented Apr 1, 2022

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 1, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Apr 1, 2022

@bors retry timeout

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2022
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Apr 1, 2022

⌛ Testing commit 15b2d1a with merge eb82fac...

@bors
Copy link
Contributor

bors commented Apr 1, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing eb82fac to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 1, 2022
@bors bors merged commit eb82fac into rust-lang:master Apr 1, 2022
@rustbot rustbot added this to the 1.61.0 milestone Apr 1, 2022
@bors bors mentioned this pull request Apr 2, 2022
Closed
11 tasks
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (eb82fac): comparison url.

Summary:

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: no relevant changes found. 4 results were found to be statistically significant but too small to be relevant.
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 0 3 0 1 0
mean2 N/A 0.3% N/A -0.3% NaN%
max N/A 0.3% N/A -0.3% 0.0%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. number of relevant changes ↩

  2. the arithmetic mean of the percent change ↩

@Kobzol Kobzol mentioned this pull request Apr 2, 2022
Merged
@cjgillot cjgillot deleted the flat-metadata branch April 2, 2022 13:42
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.
7 participants
@cjgillot @rust-highfive @rust-timer @bors @oli-obk @rust-log-analyzer @rustbot