Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perf test/don't merge] Revert "RustWrapper: add missing include" #94992

Closed
wants to merge 1 commit into from

Conversation

matthiaskrgr
Copy link
Member

This reverts commit 185e3b9.
cc #94814 (comment)

r? @ghost

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 16, 2022
@matthiaskrgr
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 16, 2022
@bors
Copy link
Contributor

bors commented Mar 16, 2022

⌛ Trying commit 1146ecd with merge 8a8cc149d565af08f8e5921bdda595ceff446e5f...

@bors
Copy link
Contributor

bors commented Mar 16, 2022

☀️ Try build successful - checks-actions
Build commit: 8a8cc149d565af08f8e5921bdda595ceff446e5f (8a8cc149d565af08f8e5921bdda595ceff446e5f)

@rust-timer
Copy link
Collaborator

Queued 8a8cc149d565af08f8e5921bdda595ceff446e5f with parent af446e1, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8a8cc149d565af08f8e5921bdda595ceff446e5f): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Mar 16, 2022
@apiraino
Copy link
Contributor

apiraino commented Apr 7, 2022

Changing labels to signal that it not yet ready for review

@rustbot label -S-waiting-on-review +S-experimental

@rustbot rustbot added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants