-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
erase late-bound regions in dyn projection types for debuginfo #95020
Conversation
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
03aea55
to
b69b3d0
Compare
cc: @jackh726, @michaelwoerister, or @lqd if one of yall care to review this since y'all were involved in #94998 and related issues. |
Could this fix some of the older tickets as well, or are these "different" bugs? |
@matthiaskrgr probably not, since I think this is not a generalized fix, and each of these is likely due to a unique mishandling of #92537 and #92271 might be related/fixed by this one, though, since it has to do with debuginfo, though I am unable to test them because I don't have a windows machine. |
@bors delegate+ p=1 r=me on this. Not sure if @michaelwoerister has any additional thoughts for e.g. debug symbol names for the test. Let's make sure this hits nightly either way; seems to be getting hit a lot and we can also add more thorough tests. |
✌️ @compiler-errors can now approve this pull request |
CI is passing and Jack had a good point to get it into tonight's nightly, so I will land this now. @michaelwoerister please let me know if I should do any follow-up fixes. @bors r=jackh726 |
📌 Commit b69b3d0 has been approved by |
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
Hiya @Dylan-DPC! The tree is closed due to #94997 which is another debuginfo fix, right? Can I p=100 this to make sure it lands on the next nightly, or do we expect the tree to open soon? edit: Oh, tree is closed due to infra issues. nvm! |
@bors treeclosed- |
⌛ Testing commit b69b3d0 with merge 7142f4c41789d00f4e890aab871942853b93540d... |
💔 Test failed - checks-actions |
@bors treeclosed=100 |
@bors r=jackh726 |
💡 This pull request was already approved, no need to approve it again.
|
📌 Commit b69b3d0 has been approved by |
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
https://www.githubstatus.com/ is green again so let's see if we can re-open the tree... |
⌛ Testing commit b69b3d0 with merge 91f598a88570d1cf2f2f86876065a2a6f8d184ba... |
@RalfJung: this will probably fail again until @ehuss is done investigating issues with the ppc64-linux target in #95046. I don't think bors was failing just because of github issues. See the zulip thread. |
💔 Test failed - checks-actions |
@bors treeclosed=100 |
@bors retry |
Oh, sorry -- the timing made it look like this was due to the GH issues... |
☀️ Test successful - checks-actions |
Finished benchmarking commit (4ca56d2): comparison url. Summary: This benchmark run did not return any relevant results. 3 results were found to be statistically significant but too small to be relevant. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
simply skipping the binder leaves late-bound regions that will cause debug assertions to fail when checking the layout of the projection ty, so let's erase the regions instead.
sorry for taking so long to put this up, had trouble getting rustc set up on a new computer.
fixes #94998