ptr_metadata test: avoid ptr-to-int transmutes #95516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
dtolnay
approved these changes
Mar 31, 2022
|
@bors r+ rollup |
|
📌 Commit 907ba11 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 31, 2022
ptr_metadata test: avoid ptr-to-int transmutes Pointers can have provenance, integers don't, so transmuting pointers to integers creates "non-standard" values and it is unclear how well those can be supported (rust-lang/unsafe-code-guidelines#286). So for this test let's take the safer option and use a pointer type instead. That also makes Miri happy. :)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 1, 2022
ptr_metadata test: avoid ptr-to-int transmutes Pointers can have provenance, integers don't, so transmuting pointers to integers creates "non-standard" values and it is unclear how well those can be supported (rust-lang/unsafe-code-guidelines#286). So for this test let's take the safer option and use a pointer type instead. That also makes Miri happy. :)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 1, 2022
…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#95475 (rustdoc: Only show associated consts from inherent impls in sidebar) - rust-lang#95516 (ptr_metadata test: avoid ptr-to-int transmutes) - rust-lang#95528 (skip slow int_log tests in Miri) - rust-lang#95531 (expand: Do not count metavar declarations on RHS of `macro_rules`) - rust-lang#95532 (make utf8_char_counts test faster in Miri) - rust-lang#95546 (add notes about alignment-altering reallocations to Allocator docs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pointers can have provenance, integers don't, so transmuting pointers to integers creates "non-standard" values and it is unclear how well those can be supported (rust-lang/unsafe-code-guidelines#286).
So for this test let's take the safer option and use a pointer type instead. That also makes Miri happy. :)