Additional *mut [T] methods
#95594
Merged
Additional *mut [T] methods
#95594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This was referenced Apr 2, 2022
Split out from rust-lang#94247 This adds the following methods to raw slices that already exist on regular slices * `*mut [T]::is_empty` * `*mut [T]::split_at_mut` * `*mut [T]::split_at_unchecked` These methods reduce the amount of unsafe code needed to migrate ChunksMut and related iterators to raw slices (rust-lang#94247) Co-authored-by:: The 8472 <[email protected]>
the8472
force-pushed
the
raw_slice_methods
branch
from
e39d006 to
a671fa1
Compare
|
The implementations of |
|
Indexing raw slices could be useful, but I think that should go into a separate PR if we want to mirror SliceIndex. Plus we'd still need |
dtolnay
added
the
T-libs-api
BoxyUwU
reviewed
Apr 3, 2022
`&mut [T]` implies validity which automatically makes `ptr::add` ok within its bounds. But `*mut [T]` does not. Since we still want the benefits of in-bounds pointer arithmetic `split_at_must` must require the caller to pass valid pointers and therefore it is `unsafe`.
the8472
force-pushed
the
raw_slice_methods
branch
from
1ee3594 to
b0ca46e
Compare
JohnCSimon
added
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
|
Hi, this PR has been open for a while with no activity and I think it's blocking me from fixing what I think is a soundness issue in the standard library: #94231 This is just a PR to add new methods behind features so I don't think it should be a lot of work to move this forward, but please let me know if there's something I can do to help. |
yaahc
reviewed
May 31, 2022
|
@bors r+ |
|
📌 Commit b0ca46e has been approved by |
bors
added
S-waiting-on-bors
7 tasks
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 1, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#95594 (Additional `*mut [T]` methods) - rust-lang#97130 (rustdoc: avoid including impl blocks with filled-in generics) - rust-lang#97166 (Move conditions out of recover/report functions.) - rust-lang#97605 (Mention filename in suggestion when it differs from primary span) - rust-lang#97613 (rustdoc: Improve calculation of "Impls on Foreign Types") - rust-lang#97626 (rename PointerAddress → PointerExposeAddress) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #94247
This adds the following methods to raw slices that already exist on regular slices
*mut [T]::is_empty*mut [T]::split_at_mut*mut [T]::split_at_mut_uncheckedThese methods reduce the amount of unsafe code needed to migrate
ChunksMutand related iteratorsto raw slices (#94247)
r? @m-ou-se