Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverts Mention implementers of unsatisfied trait #95703

Closed
wants to merge 7 commits into from
Closed

Reverts Mention implementers of unsatisfied trait #95703

wants to merge 7 commits into from

Conversation

Dylan-DPC
Copy link
Member

Reverts #91873

context

r? @ghost

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 5, 2022
@Dylan-DPC
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 5, 2022
@bors
Copy link
Contributor

bors commented Apr 5, 2022

⌛ Trying commit ecb0a11 with merge 1423a52492255f39b3f99dd40f9e7a61bca4c1db...

@bors
Copy link
Contributor

bors commented Apr 5, 2022

☀️ Try build successful - checks-actions
Build commit: 1423a52492255f39b3f99dd40f9e7a61bca4c1db (1423a52492255f39b3f99dd40f9e7a61bca4c1db)

@rust-timer
Copy link
Collaborator

Queued 1423a52492255f39b3f99dd40f9e7a61bca4c1db with parent f262ca1, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1423a52492255f39b3f99dd40f9e7a61bca4c1db): comparison url.

Summary:

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: changes not relevant. 1 results were found to be statistically significant but the changes were too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Apr 6, 2022
@Dylan-DPC Dylan-DPC marked this pull request as draft April 6, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Dylan-DPC @rust-timer @bors @Mark-Simulacrum @rustbot