Update Clippy #95772

flip1995 · 2022-04-07T15:57:47Z

remove `ref`/`ref mut` check

Taking a Diagnostic by move would break the usual pattern `diag.label(..).emit()`.

Update Clippy r? `@Manishearth`

…earth Changelog for Rust 1.60.0 🦀 (Kudos to everyone who contributed!) As always, I'm impressed by how much stuff happened in just one release. Seriously, kudos to everyone who contributed. changelog: none

Remove `Session::one_time_diagnostic` This is untracked mutable state, which modified the behaviour of queries. It was used for 2 things: some full-blown errors, but mostly for lint declaration notes ("the lint level is defined here" notes). It is replaced by the diagnostic deduplication infra which already exists in the diagnostic emitter. A new diagnostic level `OnceNote` is introduced specifically for lint notes, to deduplicate subdiagnostics. As a drive-by, diagnostic emission takes a `&mut` to allow dropping the `SubDiagnostic`s.

- should not fire if indexing with a constant block - should not fire if indexing within a constant context (const statement or const block)

add #[must_use] to functions of slice and its iterators. Continuation of rust-lang#92853. Tracking issue: rust-lang#89692.

Check if lhs < rhs in modulos in `identity_op` Fixes rust-lang#8508 changelog: [`identity_op`] now checks for modulos, e.g. `1 % 3`

[`map_identity`] checks for needless `map_err` Closes rust-lang#8478 changelog: [`map_identity`] checks for needless `map_err`

flip1995 · 2022-04-07T16:09:34Z

@bors r- (fixing CI in a minute)

flip1995 · 2022-04-07T16:24:01Z

Wait, I don't understand this error. The .sf is a Lrc<SourceFile>, which is an Rc<SourceFile> IIUC. I also can't reproduce this locally. 🤔

update_lints now understands raw strings in declare_clippy_lint descriptions. Co-authored-by: Alex Macleod <[email protected]>

Allow raw lint descriptions update_lints now understands raw strings in declare_clippy_lint descriptions. Supersedes rust-lang#8655 cc `@Alexendoo` thanks for addressing this so quickly. I build a little bit simpler version of your patch. I don't think it really matters what `Literal` we're trying to tokenize, since we assume later, that it is some sort of `str`. changelog: none

Manishearth · 2022-04-07T17:41:27Z

@bors r+

bors · 2022-04-07T17:41:28Z

📌 Commit 1390d014303fd52faad9424a7e801df0ea6c70e9 has been approved by Manishearth

flip1995 · 2022-04-07T17:48:07Z

That didn't fix it.... I'm out of ideas here and already spent 5 hours with syncing and releasing Clippy today. I try to get back to this tomorrow or over the weekend.

flip1995 · 2022-04-07T17:48:18Z

@bors r-

flip1995 · 2022-04-08T09:56:47Z

That should work now

@bors r=Manishearth,flip1995

bors · 2022-04-08T09:56:48Z

📌 Commit b590d5c has been approved by Manishearth,flip1995

bors · 2022-04-08T13:22:16Z

⌛ Testing commit b590d5c with merge 2d5a21f...

bors · 2022-04-08T15:50:30Z

☀️ Test successful - checks-actions
Approved by: Manishearth,flip1995
Pushing 2d5a21f to master...

rust-timer · 2022-04-08T17:03:38Z

Finished benchmarking commit (2d5a21f): comparison url.

Summary:

Primary benchmarks: no relevant changes found
Secondary benchmarks: mixed results

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count¹	0	2	0	1	0
mean²	N/A	1.1%	N/A	-0.3%	N/A
max	N/A	1.9%	N/A	-0.3%	N/A

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

number of relevant changes ↩
the arithmetic mean of the percent change ↩

dswij and others added 30 commits March 1, 2022 12:47

map_identity checks for unneeded .map_err

35b1453

map_identity Add tests for needless .map_err

3d1f83e

Check if lhs < rhs in modulos and emit

a944ccb

Rework undocumented_unsafe_blocks

65f96e2

Don't lint undocumented_unsafe_blocks on bad proc-macro spans.

30b3336

quick fix of issue#8542 for lint [needless_match]

2909b33

remove `ref`/`ref mut` check

fix rust-lang#8551, add test cases, and some code improvement

4b12862

Take &mut Diagnostic in emit_diagnostic.

94c727e

Taking a Diagnostic by move would break the usual pattern `diag.label(..).emit()`.

Add crate_in_macro_def lint

65a2669

update clippy stderr file

6fc3850

Typo

8687205

Merge commit 'd0cf3481a84e3aa68c2f185c460e282af36ebc42' into clippyup

1fa3d66

Auto merge of rust-lang#95273 - flip1995:clippyup, r=manishearth

b7b0dad

Update Clippy r? `@Manishearth`

Update clippy helper function types

854c3de

Changelog for Rust 1.60.0 🦀

55feb4c

Auto merge of rust-lang#8582 - xFrednet:0000-changelog-1-60, r=Manish…

8ebe766

…earth Changelog for Rust 1.60.0 🦀 (Kudos to everyone who contributed!) As always, I'm impressed by how much stuff happened in just one release. Seriously, kudos to everyone who contributed. changelog: none

Provide suggestion context in map_unit_fn

610db04

specify serde version compatible with codebase

bca047d

fix indexing_slicing with const

21eae8c

- should not fire if indexing with a constant block - should not fire if indexing within a constant context (const statement or const block)

add #[must_use] to functions of slice and its iterators.

96f4e1c

add #[must_use] to functions of slice and its iterators.

41f1413

Do not fire panic in a constant environment

c687f65

Rustfmt

af8ed04

Auto merge of rust-lang#95274 - jendrikw:slice-must-use, r=Dylan-DPC

a7da8a6

add #[must_use] to functions of slice and its iterators. Continuation of rust-lang#92853. Tracking issue: rust-lang#89692.

Emit lint when rhs is negative

52b563b

Auto merge of rust-lang#8519 - tysg:redundant-modulo, r=giraffate

59c0f29

Check if lhs < rhs in modulos in `identity_op` Fixes rust-lang#8508 changelog: [`identity_op`] now checks for modulos, e.g. `1 % 3`

Auto merge of rust-lang#8487 - dswij:8478, r=giraffate

6206086

[`map_identity`] checks for needless `map_err` Closes rust-lang#8478 changelog: [`map_identity`] checks for needless `map_err`

First submit

ec851b8

Address review comments

cb307bb

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 7, 2022

flip1995 and others added 2 commits April 7, 2022 18:05

Allow raw lint descriptions

6ab4508

update_lints now understands raw strings in declare_clippy_lint descriptions. Co-authored-by: Alex Macleod <[email protected]>

flip1995 force-pushed the clippyup branch from f0a03a5 to 1390d01 Compare April 7, 2022 17:40

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 7, 2022

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 7, 2022

flip1995 added 2 commits April 8, 2022 10:06

Merge commit '984330a6ee3c4d15626685d6dc8b7b759ff630bd' into clippyup

515e2a2

Update Cargo.lock

b590d5c

flip1995 force-pushed the clippyup branch from f5cc462 to b590d5c Compare April 8, 2022 09:42

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 8, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 8, 2022

bors merged commit 2d5a21f into rust-lang:master Apr 8, 2022

rustbot added this to the 1.62.0 milestone Apr 8, 2022

flip1995 deleted the clippyup branch April 10, 2022 21:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Clippy #95772

Update Clippy #95772

flip1995 commented Apr 7, 2022

flip1995 commented Apr 7, 2022

flip1995 commented Apr 7, 2022

Manishearth commented Apr 7, 2022

bors commented Apr 7, 2022

This comment has been minimized.

flip1995 commented Apr 7, 2022 •

edited

Loading

flip1995 commented Apr 7, 2022

flip1995 commented Apr 8, 2022

bors commented Apr 8, 2022

bors commented Apr 8, 2022

bors commented Apr 8, 2022

rust-timer commented Apr 8, 2022

Update Clippy #95772

Update Clippy #95772

Conversation

flip1995 commented Apr 7, 2022

flip1995 commented Apr 7, 2022

flip1995 commented Apr 7, 2022

Manishearth commented Apr 7, 2022

bors commented Apr 7, 2022

This comment has been minimized.

flip1995 commented Apr 7, 2022 • edited Loading

flip1995 commented Apr 7, 2022

flip1995 commented Apr 8, 2022

bors commented Apr 8, 2022

bors commented Apr 8, 2022

bors commented Apr 8, 2022

rust-timer commented Apr 8, 2022

Footnotes

flip1995 commented Apr 7, 2022 •

edited

Loading