rustdoc doctest: include signal number in exit status #95783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-rustdoc
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
approved these changes
Apr 8, 2022
|
Thanks! @bors: r+ rollup |
|
@GuillaumeGomez it looks like bors didn’t hear you. |
|
@bors r=GuillaumeGomez |
|
📌 Commit 898ff01 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 898ff01 with merge 270a3e16d0227949c9f1912385c850e6086e5c38... |
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
Submitted a fixed version of this thing for Windows, which now produces very subtly different output. |
This comment has been minimized.
This comment has been minimized.
notriddle
force-pushed
the
notriddle/doctest-signal
branch
from
f4970ac to
daa903c
Compare
Co-authored-by: Guillaume Gomez <[email protected]>
|
Thanks! @bors: r+ rollup |
|
📌 Commit 2af843c has been approved by |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 12, 2022
Rollup of 4 pull requests Successful merges: - rust-lang#95783 (rustdoc doctest: include signal number in exit status) - rust-lang#95794 (`parse_tt`: a few more tweaks) - rust-lang#95963 ([bootstrap] Grab the right FileCheck binary for dist when cross-compiling.) - rust-lang#95975 (Don't test -Cdefault-linker-libraries=yes when cross compiling.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #95601