-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update stdarch #95958
Update stdarch #95958
Conversation
Thank you for submitting a new PR for the library teams! If this PR contains a stabilization of a library feature that has not already completed FCP in its tracking issue, introduces new or changes existing unstable library APIs, or changes our public documentation in ways that create new stability guarantees then please comment with |
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ rollup=never |
📌 Commit 2638e96 has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (dc4bfcb): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Footnotes |
Visiting for weekly performance triage. This causes a 1.11% performance regression on a single primary benchmark, namely unicode-normalization-0.1.19 debug full. I am vaguely curious what the root cause might be. Not sure how much time I want to invest in finding out, but I will hold off on marking this as triaged until later this evening when I might have chance to look at some cachegrind output or something. (Currently my best guess is it might have something to do with the switch from the "change remaining undefined functions to zero-init" in the changes listed in the description.) |
I have done a number of local cachegrind runs to try to evaluate the root cause, and so far my main finding is that I'm seeing a lot of noise in the data this yields. The total number of instruction counts is on the order of 4,182M +/- 1M., but the point is that sometimes the cachegrind diff says that the results went down by 1.4M, and other times it says it went up by 3M. Overall it seems like the regression being flagged here may be in the noise overall. @rustbot label: +perf-regression-triaged |
…mpiler-errors Remove `#[rustc_deprecated]` This removes `#[rustc_deprecated]` and introduces diagnostics to help users to the right direction (that being `#[deprecated]`). All uses of `#[rustc_deprecated]` have been converted. CI is expected to fail initially; this requires rust-lang#95958, which includes converting `stdarch`. I plan on following up in a short while (maybe a bootstrap cycle?) removing the diagnostics, as they're only intended to be short-term.
library/stdarch bcbe010...d215afe (7):
#[rustc_deprecated]