Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stdarch #95958

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Update stdarch #95958

merged 1 commit into from
Apr 13, 2022

Conversation

jhpratt
Copy link
Member

@jhpratt jhpratt commented Apr 12, 2022

library/stdarch bcbe010...d215afe (7):

@rust-highfive
Copy link
Collaborator

Thank you for submitting a new PR for the library teams! If this PR contains a stabilization of a library feature that has not already completed FCP in its tracking issue, introduces new or changes existing unstable library APIs, or changes our public documentation in ways that create new stability guarantees then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary

@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 12, 2022
@Dylan-DPC
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Apr 12, 2022

📌 Commit 2638e96 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 12, 2022
@bors
Copy link
Contributor

bors commented Apr 13, 2022

⌛ Testing commit 2638e96 with merge dc4bfcb...

@bors
Copy link
Contributor

bors commented Apr 13, 2022

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing dc4bfcb to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 13, 2022
@bors bors merged commit dc4bfcb into rust-lang:master Apr 13, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 13, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (dc4bfcb): comparison url.

Summary:

  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: 😿 relevant regressions found
Regressions 😿
(primary)
Regressions 😿
(secondary)
Improvements 🎉
(primary)
Improvements 🎉
(secondary)
All 😿 🎉
(primary)
count1 1 8 0 0 1
mean2 1.1% 0.7% N/A N/A 1.1%
max 1.1% 1.2% N/A N/A 1.1%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

Footnotes

  1. number of relevant changes

  2. the arithmetic mean of the percent change

@rustbot rustbot added the perf-regression Performance regression. label Apr 13, 2022
@jhpratt jhpratt deleted the bump-stdarch branch April 13, 2022 23:33
@pnkfelix
Copy link
Member

Visiting for weekly performance triage.

This causes a 1.11% performance regression on a single primary benchmark, namely unicode-normalization-0.1.19 debug full.

I am vaguely curious what the root cause might be. Not sure how much time I want to invest in finding out, but I will hold off on marking this as triaged until later this evening when I might have chance to look at some cachegrind output or something. (Currently my best guess is it might have something to do with the switch from the "change remaining undefined functions to zero-init" in the changes listed in the description.)

@pnkfelix
Copy link
Member

I have done a number of local cachegrind runs to try to evaluate the root cause, and so far my main finding is that I'm seeing a lot of noise in the data this yields. The total number of instruction counts is on the order of 4,182M +/- 1M., but the point is that sometimes the cachegrind diff says that the results went down by 1.4M, and other times it says it went up by 3M.

Overall it seems like the regression being flagged here may be in the noise overall.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Apr 20, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request May 9, 2022
…mpiler-errors

Remove `#[rustc_deprecated]`

This removes `#[rustc_deprecated]` and introduces diagnostics to help users to the right direction (that being `#[deprecated]`). All uses of `#[rustc_deprecated]` have been converted. CI is expected to fail initially; this requires rust-lang#95958, which includes converting `stdarch`.

I plan on following up in a short while (maybe a bootstrap cycle?) removing the diagnostics, as they're only intended to be short-term.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants