Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update validate_uninhabited_zsts.rs test after MIR building changes #96272

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Apr 21, 2022

to ensure that it still tests validation, instead of failing earlier on
during evaluation.

r? @RalfJung

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 21, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 21, 2022
@tmiasko tmiasko force-pushed the validate-uninhabited branch from 0f53528 to c124759 Compare April 21, 2022 09:05
@RalfJung
Copy link
Member

Specifically, this is a follow-up to #93313.

LGTM! r=me with a comment added.

to ensure that it still tests validation, instead of failing earlier on
during evaluation.
@tmiasko tmiasko force-pushed the validate-uninhabited branch from c124759 to 9ff5b7e Compare April 21, 2022 19:53
@tmiasko
Copy link
Contributor Author

tmiasko commented Apr 21, 2022

@bors r=RalfJung rollup=always

@bors
Copy link
Contributor

bors commented Apr 21, 2022

📌 Commit 9ff5b7e has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 22, 2022
…askrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#96272 (Update `validate_uninhabited_zsts.rs` test after MIR building changes)
 - rust-lang#96273 (Make `E0117` error clear)
 - rust-lang#96315 (Make the lifetime accurate which is used in the region constraints part)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9834674 into rust-lang:master Apr 22, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 22, 2022
@tmiasko tmiasko deleted the validate-uninhabited branch May 3, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants