-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boostrap.py use curl by default #96602
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. Please see the contribution instructions for more information. |
Please also modify the downloads in |
This comment has been minimized.
This comment has been minimized.
Thanks a lot for the quick feedback!
|
This comment has been minimized.
This comment has been minimized.
@TApplencourt you can test the rust changes by setting
Not a stupid question! Codebases tend to get more complicated over time 😅 it's perfectly fine to ask for help figuring out how they work :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also keep commits squashed. Thanks!
I think I addressed all the comments. Thanks a lot for the feedback! I did some checks on my Linux machine; if I'm not sure about the naming of Thanks again for your time and your guidance! |
@jyn514, @Mark-Simulacrum If you have time, I think this is ready to review! |
@bors r+ |
📌 Commit ad7dbe1 has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (0be8768): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Thanks a lot y'all for the guidance on this one! |
Thank you for working on it! |
Fixes #61611