Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos in arg checking algorithm #97303

Merged
merged 1 commit into from
May 23, 2022

Conversation

compiler-errors
Copy link
Member

Fixes #97197

Also fixes a typo where if we're missing args A, B, C, we actually say A, B, B

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 23, 2022
@rust-highfive
Copy link
Collaborator

r? @nagisa

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 23, 2022
@compiler-errors
Copy link
Member Author

r? @jackh726 since you wrote this code I think

Also nominating for beta backport because this hit beta apparently, see #97197 .

@rust-highfive rust-highfive assigned jackh726 and unassigned nagisa May 23, 2022
@compiler-errors compiler-errors added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 23, 2022
@jackh726
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 23, 2022

📌 Commit 21a7b4c has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 23, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request May 23, 2022
Rollup of 5 pull requests

Successful merges:

 - rust-lang#97087 (Clarify slice and Vec iteration order)
 - rust-lang#97254 (Remove feature: `crate` visibility modifier)
 - rust-lang#97271 (Add regression test for rust-lang#91949)
 - rust-lang#97294 (std::time : fix variable name in the doc)
 - rust-lang#97303 (Fix some typos in arg checking algorithm)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b5ff4ad into rust-lang:master May 23, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 23, 2022
@apiraino
Copy link
Contributor

Beta backport accepted as per compiler team on Zulip

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label May 26, 2022
@ehuss ehuss modified the milestones: 1.63.0, 1.62.0 Jun 1, 2022
ehuss pushed a commit to ehuss/rust that referenced this pull request Jun 1, 2022
Fix some typos in arg checking algorithm

Fixes rust-lang#97197

Also fixes a typo where if we're missing args A, B, C, we actually say A, B, B
@ehuss ehuss mentioned this pull request Jun 1, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 2, 2022
[beta] Beta backports

* Allow the unused_macro_rules lint for now rust-lang#97032
* Fix some typos in arg checking algorithm rust-lang#97303
* rustc: Fix ICE in native library error reporting rust-lang#97328
* Cargo:
    * Fix `cargo publish -p spec` rust-lang/cargo#10707
@ehuss ehuss removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 23, 2022
@compiler-errors compiler-errors deleted the arg-typos branch August 11, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index out of bounds while checking function arguments
8 participants