Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more eslint rules #97394

Merged
merged 7 commits into from
May 26, 2022
Merged

Add more eslint rules #97394

merged 7 commits into from
May 26, 2022

Conversation

GuillaumeGomez
Copy link
Member

This PR adds more eslint rules. Here are the explanations for each of them:

r? @notriddle

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label May 25, 2022
@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez,@Folyd,@jsha

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 25, 2022
@GuillaumeGomez GuillaumeGomez added the A-rustdoc-js Area: Rustdoc's JS front-end label May 25, 2022
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-llvm-12 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
* highest error code: E0787
Found 504 error codes
Found 0 error(s) in error codes
Done!
thread '<unnamed>' panicked at 'cmd.exec() failed with `cargo metadata` exited with an error:     Updating git repository `https://github.com/bjorn3/rust-ar.git`
warning: spurious network error (2 tries remaining): failed to connect to github.com: Connection timed out; class=Os (2)
warning: spurious network error (1 tries remaining): failed to connect to github.com: Connection timed out; class=Os (2)
error: failed to get `ar` as a dependency of package `rustc_codegen_cranelift v0.1.0 (/checkout/compiler/rustc_codegen_cranelift)`
Caused by:
  failed to load source for dependency `ar`

Caused by:
Caused by:
  Unable to update https://github.com/bjorn3/rust-ar.git?branch=do_not_remove_cg_clif_ranlib#de9ab0e5

Caused by:
  failed to clone into: /cargo/git/db/rust-ar-9b35aff8ad678e06
Caused by:
Caused by:
  failed to connect to github.com: Connection timed out; class=Os (2)', src/tools/tidy/src/deps.rs:320:20
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Any { .. }', src/tools/tidy/src/main.rs:92:9

@notriddle
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented May 25, 2022

📌 Commit bb29d5d has been approved by notriddle

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 25, 2022
@GuillaumeGomez
Copy link
Member Author

@bors rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request May 25, 2022
…laumeGomez

Rollup of 4 pull requests

Successful merges:

 - rust-lang#97317 (Allow to click on setting text)
 - rust-lang#97375 (Simplify implementation of `-Z gcc-ld`)
 - rust-lang#97394 (Add more eslint rules)
 - rust-lang#97407 (Update books)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d932610 into rust-lang:master May 26, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 26, 2022
@GuillaumeGomez GuillaumeGomez deleted the more-eslint-rules branch May 26, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-js Area: Rustdoc's JS front-end S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants