Arc make_mut doc comment spelling correction. #97603
Conversation
rustbot
added
the
T-libs
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
library/alloc/src/sync.rs
Outdated
| @@ -1397,7 +1397,7 @@ impl<T: Clone> Arc<T> { | |||
| /// be cloned. | |||
| /// | |||
| /// See also [`get_mut`], which will fail rather than cloning the inner value | |||
| /// or diassociating [`Weak`] pointers. | |||
| /// or disassociating [`Weak`] pointers. | |||
There was a problem hiding this comment.
Shouldn't it be dissociating?
There was a problem hiding this comment.
The paragraph above also says "disassociated" so this change would be consistent with that. From Googling I see that the two terms are synonyms having the same meaning and also being about the same age. Personally I don't use "dissociate" but instead use "disassociate", perhaps that's just what I grew up with in England, I assumed, wrongly it seems, that "dissociate" was American English
There was a problem hiding this comment.
Oh well, today both learned. I didn't know they meant the same thing or that "disassociate" existed ("disassociate" is actually closer to french so makes more sense to me ;) ).
library/alloc/src/sync.rs
Outdated
| @@ -1393,11 +1393,11 @@ impl<T: Clone> Arc<T> { | |||
| /// referred to as clone-on-write. | |||
| /// | |||
| /// However, if there are no other `Arc` pointers to this allocation, but some [`Weak`] | |||
| /// pointers, then the [`Weak`] pointers will be disassociated and the inner value will not | |||
| /// pointers, then the [`Weak`] pointers will be disociated and the inner value will not | |||
|
@bors r=GuillaumeGomez rollup |
|
📌 Commit f81269f has been approved by |
bors
added
S-waiting-on-bors
Rollup of 6 pull requests Successful merges: - rust-lang#96894 (Apply track_caller to closure on `expect_non_local()`) - rust-lang#97023 (Diagnose anonymous lifetimes errors more uniformly between async and regular fns) - rust-lang#97397 (Stabilize `box_into_pin`) - rust-lang#97587 (Migrate more diagnostics to use the `#[derive(SessionDiagnostic)]`) - rust-lang#97603 (Arc make_mut doc comment spelling correction.) - rust-lang#97635 (Fix file metadata documentation for Windows) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
No description provided.