Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant calls to reserve in impl Write for VecDeque #97922

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Remove redundant calls to reserve in impl Write for VecDeque #97922

merged 1 commit into from
Jun 10, 2022

Conversation

paolobarbolini
Copy link
Contributor

Removes the reserve calls made redundant by #95904 (as discussed in #95632 (comment))

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 9, 2022
@rust-highfive
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 9, 2022
@paolobarbolini paolobarbolini mentioned this pull request Jun 9, 2022
Merged
@the8472
Copy link
Member

the8472 commented Jun 9, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 9, 2022

📌 Commit c71e73e has been approved by the8472

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2022
@the8472 the8472 assigned the8472 and unassigned Mark-Simulacrum Jun 9, 2022
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jun 9, 2022
@compiler-errors
Rollup merge of rust-lang#97922 - paolobarbolini:no-vecdeque-extra-re…
09d72f5 
…serve, r=the8472

Remove redundant calls to reserve in impl Write for VecDeque

Removes the reserve calls made redundant by rust-lang#95904 (as discussed in rust-lang#95632 (comment))
@compiler-errors compiler-errors mentioned this pull request Jun 9, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 10, 2022
@Dylan-DPC
Rollup merge of rust-lang#97922 - paolobarbolini:no-vecdeque-extra-re…
eca7229 
…serve, r=the8472

Remove redundant calls to reserve in impl Write for VecDeque

Removes the reserve calls made redundant by rust-lang#95904 (as discussed in rust-lang#95632 (comment))
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 10, 2022
Closed
@leonardo-m leonardo-m mentioned this pull request Jun 10, 2022
Open
@JohnTitor JohnTitor mentioned this pull request Jun 10, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 10, 2022
@bors
Auto merge of rust-lang#97939 - JohnTitor:rollup-79pxupb, r=JohnTitor
f19ccc2 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#97718 (Fix `delayed_good_path_bug` ice for expected diagnostics (RFC 2383))
 - rust-lang#97876 (update docs for `std::future::IntoFuture`)
 - rust-lang#97888 (Don't use __gxx_personality_v0 in panic_unwind on emscripten target)
 - rust-lang#97922 (Remove redundant calls to reserve in impl Write for VecDeque)
 - rust-lang#97927 (Do not introduce bindings for types and consts in HRTB.)
 - rust-lang#97937 (Fix a typo in `test/ui/hrtb/hrtb-just-for-static.rs`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3e5ddb7 into rust-lang:master Jun 10, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@the8472 the8472

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
6 participants
@paolobarbolini @rust-highfive @the8472 @bors @Mark-Simulacrum @rustbot