Remove thread-local IGNORED_ATTRIBUTES.

[nnethercote]

It's just a copy of the read-only global ich::IGNORED_ATTRIBUTES, and
can be removed without any effect.

r? @michaelwoerister

[nnethercote]

@bors rollup=always

[michaelwoerister]

Thanks, @nnethercote! That was probably meant as on optimization (HashMap vs linear list lookup). But if it doesn't affect performance, let's remove it.

@bors r+

[bors]

📌 Commit a280162 has been approved by michaelwoerister

[bjorn3]

Previously this would do a HashSet lookup in O(1). Now it does a Vec search in O(n).

[michaelwoerister]

Previously this would do a HashSet lookup in O(1). Now it does a Vec search in O(n).

Let's make sure we get a clean perf run for this, so we can revert if necessary:
@bors rollup=never

We could also consider using a lazy static hashmap here.

[bors]

⌛ Testing commit a280162 with merge 8beb2bd30e3ef75759d48d465c57aae0893d02ae...

[bors]

💔 Test failed - checks-actions

[rust-log-analyzer]

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin/miri" "--edition" "2018" "-Astable-features" "--sysroot" "/home/user/.cache/miri/HOST" "-Zui-testing" "tests/pass/threadleak_ignored.rs" "--error-format=json" "-Zmiri-ignore-leaks"

Pass got exit status: 1

actual output differed from expected tests/pass/threadleak_ignored.stderr
Diff < left / right > :
<Dropping 0
>error: Undefined Behavior: deallocating while item is protected: [SharedReadWrite for <TAG> (call ID)]
>  --> RUSTLIB/alloc/src/alloc.rs:LL:CC
>   |
>LL |     unsafe { __rust_dealloc(ptr, layout.size(), layout.align()) }
>   |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ deallocating while item is protected: [SharedReadWrite for <TAG> (call ID)]
>   |
>   = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental
>           
>   = note: inside `std::alloc::dealloc` at RUSTLIB/alloc/src/alloc.rs:LL:CC
>   = note: inside `<std::alloc::Global as std::alloc::Allocator>::deallocate` at RUSTLIB/alloc/src/alloc.rs:LL:CC
>   = note: inside `<std::sync::Weak<std::sync::mpsc::blocking::Inner> as std::ops::Drop>::drop` at RUSTLIB/alloc/src/sync.rs:LL:CC
>   = note: inside `<std::sync::Weak<std::sync::mpsc::blocking::Inner> as std::ops::Drop>::drop` at RUSTLIB/alloc/src/sync.rs:LL:CC
>   = note: inside `std::ptr::drop_in_place::<std::sync::Weak<std::sync::mpsc::blocking::Inner>> - shim(Some(std::sync::Weak<std::sync::mpsc::blocking::Inner>))` at RUSTLIB/core/src/ptr/mod.rs:LL:CC
>   = note: inside `std::mem::drop::<std::sync::Weak<std::sync::mpsc::blocking::Inner>>` at RUSTLIB/core/src/mem/mod.rs:LL:CC
>   = note: inside `std::sync::Arc::<std::sync::mpsc::blocking::Inner>::drop_slow` at RUSTLIB/alloc/src/sync.rs:LL:CC
>   = note: inside `<std::sync::Arc<std::sync::mpsc::blocking::Inner> as std::ops::Drop>::drop` at RUSTLIB/alloc/src/sync.rs:LL:CC
>   = note: inside `std::ptr::drop_in_place::<std::sync::Arc<std::sync::mpsc::blocking::Inner>> - shim(Some(std::sync::Arc<std::sync::mpsc::blocking::Inner>))` at RUSTLIB/core/src/ptr/mod.rs:LL:CC
>   = note: inside `std::ptr::drop_in_place::<std::sync::mpsc::blocking::SignalToken> - shim(Some(std::sync::mpsc::blocking::SignalToken))` at RUSTLIB/core/src/ptr/mod.rs:LL:CC
>   = note: inside `std::sync::mpsc::oneshot::Packet::<()>::send` at RUSTLIB/std/src/sync/mpsc/oneshot.rs:LL:CC
>   = note: inside `std::sync::mpsc::Sender::<()>::send` at RUSTLIB/std/src/sync/mpsc/mod.rs:LL:CC
>  --> $DIR/threadleak_ignored.rs:LL:CC
>   |
>   |
>LL |         send.send(()).unwrap();
>   |         ^^^^^^^^^^^^^
>note: some details are omitted, run with `MIRIFLAGS=-Zmiri-backtrace=full` for a verbose backtrace
>
>error: aborting due to previous error
>
>
 



There were 1 unmatched diagnostics that occurred outside the testfile and had not pattern
    Error: Undefined Behavior: deallocating while item is protected: [SharedReadWrite for <10981> (call 3269)]
failures:
    tests/pass/threadleak_ignored.rs

test result: FAIL. 1 tests failed, 232 tests passed, 1 ignored, 0 filtered out
---
.......... (60/64)
...       (64/64)


/checkout/src/test/rustdoc-gui/search-filter.goml search-filter... FAILED
[ERROR] (line 6) Error: The following CSS selector "#titles" was not found: for command `wait-for: "#titles"`
Build completed unsuccessfully in 0:00:46

[nnethercote]

@bors retry

[nnethercote]

Let's do a perf run ahead of time.

@bors r-

[nnethercote]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit a280162 with merge 749b0e41927602c22d2cd581e99f43f94176e549...

[bors]

☀️ Try build successful - checks-actions
Build commit: 749b0e41927602c22d2cd581e99f43f94176e549 (749b0e41927602c22d2cd581e99f43f94176e549)

[rust-timer]

Queued 749b0e41927602c22d2cd581e99f43f94176e549 with parent 1f34da9, future comparison URL.

[rust-timer]

Finished benchmarking commit (749b0e41927602c22d2cd581e99f43f94176e549): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

• Primary benchmarks: 🎉 relevant improvement found
• Secondary benchmarks: 😿 relevant regression found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	4.1%	4.1%	1
Improvements 🎉 (primary)	-0.8%	-0.8%	1
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	-0.8%	-0.8%	1

Cycles

Results

• Primary benchmarks: 🎉 relevant improvement found
• Secondary benchmarks: 🎉 relevant improvement found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-1.5%	-1.5%	1
Improvements 🎉 (secondary)	-2.5%	-2.5%	1
All 😿🎉 (primary)	-1.5%	-1.5%	1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩²

2. number of relevant changes ↩ ↩²

[nnethercote]

Perf results are neutral.

@bors r=michaelwoerister

[bors]

📌 Commit a280162 has been approved by michaelwoerister

[bors]

⌛ Testing commit a280162 with merge ebe184a...

[bors]

☀️ Test successful - checks-actions
Approved by: michaelwoerister
Pushing ebe184a to master...

[rust-timer]

Finished benchmarking commit (ebe184a): comparison url.

Instruction count

• Primary benchmarks: 😿 relevant regression found
• Secondary benchmarks: 😿 relevant regression found

	mean1	max	count2
Regressions 😿 (primary)	0.6%	0.6%	1
Regressions 😿 (secondary)	0.9%	0.9%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	0.6%	0.6%	1

Max RSS (memory usage)

Results

• Primary benchmarks: 🎉 relevant improvement found
• Secondary benchmarks: mixed results

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	4.2%	4.2%	1
Improvements 🎉 (primary)	-0.7%	-0.7%	1
Improvements 🎉 (secondary)	-3.8%	-4.0%	2
All 😿🎉 (primary)	-0.7%	-0.7%	1

Cycles

Results

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: 😿 relevant regression found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	2.1%	2.1%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	N/A	N/A	0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³

[nnethercote]

The previous perf run was neutral. The post-merging one had two regressions, but I am confident they're just noise. A real regression would show up more consistently, e.g. multiple regressions on a single benchmark.

@rustbot perf-regression-triaged