-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GDB/LLDB pretty-printers for NonZero types #98301
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
@wesleywiser saw you left a ❤️ reaction - would you be comfortable approving the PR? I haven't touched debuginfo much but my understanding is you're currently leading the debugging WG :) |
@bors r+ rollup This looks okay to me, though I'm not super familiar with the scripts. |
📌 Commit 0bc536e has been approved by |
…rk-Simulacrum Add GDB/LLDB pretty-printers for NonZero types Add GDB/LLDB pretty-printers for `NonZero` types. These pretty-printers were originally implemented for IntelliJ Rust by `@Kobzol` in intellij-rust/intellij-rust#5270. Part of rust-lang#29392.
@bors r- |
0bc536e
to
e0b6053
Compare
@matthiaskrgr Thanks for attaching the link to the logs. I tried fixing the tests and pushed the changes. However, I am not able to run the tests locally at the moment, so I am still not sure if I wrote the tests right. Just wondering, is there any way to run the debuginfo tests for this particular PR to check them before making a big rollup? |
This comment has been minimized.
This comment has been minimized.
e0b6053
to
bc6049a
Compare
ping from triage: FYI: when a PR is ready for review, send a message containing |
Sorry for the delay. I just have run the tests locally, and it looks like this PR is ready for review. @rustbot ready |
…sleywiser Add GDB/LLDB pretty-printers for NonZero types Add GDB/LLDB pretty-printers for `NonZero` types. These pretty-printers were originally implemented for IntelliJ Rust by `@Kobzol` in intellij-rust/intellij-rust#5270. Part of rust-lang#29392.
…sleywiser Add GDB/LLDB pretty-printers for NonZero types Add GDB/LLDB pretty-printers for `NonZero` types. These pretty-printers were originally implemented for IntelliJ Rust by ``@Kobzol`` in intellij-rust/intellij-rust#5270. Part of rust-lang#29392.
bc6049a
to
d8e7781
Compare
This comment has been minimized.
This comment has been minimized.
f9b8aef
to
8de1712
Compare
This comment has been minimized.
This comment has been minimized.
f233edc
to
2a26987
Compare
@wesleywiser I managed to run @rustbot ready |
@bors r=wesleywiser rollup=iffy |
…sleywiser Add GDB/LLDB pretty-printers for NonZero types Add GDB/LLDB pretty-printers for `NonZero` types. These pretty-printers were originally implemented for IntelliJ Rust by ``@Kobzol`` in intellij-rust/intellij-rust#5270. Part of rust-lang#29392.
…iaskrgr Rollup of 13 pull requests Successful merges: - rust-lang#97015 (std::io: migrate ReadBuf to BorrowBuf/BorrowCursor) - rust-lang#98301 (Add GDB/LLDB pretty-printers for NonZero types) - rust-lang#99570 (Box::from(slice): Clarify that contents are copied) - rust-lang#100296 (Add standard C error function aliases to last_os_error) - rust-lang#100520 (Add mention of `BufReader` in `Read::bytes` docs) - rust-lang#100885 (Export Cancel from std::os::fortanix_sgx::usercalls::raw) - rust-lang#100955 (Some papercuts on error::Error) - rust-lang#101002 (Provide structured suggestion for `hashmap[idx] = val`) - rust-lang#101038 (no alignment check during interning) - rust-lang#101055 (Use smaller span for suggestions) - rust-lang#101091 (Extend attrs if local_def_id exists) - rust-lang#101098 (rustc_middle: Remove `Visibility::Invisible`) - rust-lang#101102 (unstable-book-gen: use std::fs::write) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Add GDB/LLDB pretty-printers for
NonZero
types.These pretty-printers were originally implemented for IntelliJ Rust by @Kobzol in intellij-rust/intellij-rust#5270.
Part of #29392.