compiletest: add issue number param to known-bug
#98530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Mark-Simulacrum
added
S-waiting-on-author
|
r=me with commits squashed |
Mark-Simulacrum
added
S-waiting-on-author
davidkna
force-pushed
the
known-bug-ref
branch
2 times, most recently
from
acd519d to
71bdbc5
Compare
|
Not sure what happened with git here, but I hope this fixed it. |
| @@ -1,5 +1,5 @@ | |||
| // check-fail | |||
| // known-bug | |||
| // known-bug: #87735, #88526 | |||
There was a problem hiding this comment.
Hm, I didn't notice this before. This is outside the "intended" syntax we're validating; if we want to accept it, I think we should do so intentionally -- and probably update our parser to validate the prefix before # as well (no whitespace?).
There was a problem hiding this comment.
I've updated the parser. I wasn't able to compile the tests, but it seems to work as expected in the rust playground.
|
@bors r+ Thanks, I think this is OK for now, the validation isn't too critical anyway. |
|
📌 Commit 93d3359 has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jun 26, 2022
…lacrum compiletest: add issue number param to `known-bug` I was getting some errors while testing this, but I'm pretty sure that was unrelated to my changes. Closes rust-lang#98436 > Basically, instead of `// known-bug`, do `// known-bug #00000` or maybe `// known-bug chalk#00`? > > From: https://rust-lang.zulipchat.com/#narrow/stream/326866-t-types.2Fnominated/topic/.2398095.3A.20NLL.3A.20unsound.20verification.20of.20higher.20ranked.20outlives.E2.80.A6/near/287258738 I also added an `unknown` escape-hatch because I didn't find corresponding issues for every `// known-bug`. The syntax also ended up being `// known-bug: `, because of `set_name_value_directive`.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 27, 2022
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#97389 (Improve memory ordering diagnostics) - rust-lang#97780 (Check ADT field is well-formed before checking it is sized) - rust-lang#98530 (compiletest: add issue number param to `known-bug`) - rust-lang#98556 (Fix builds on Windows (closes rust-lang#98546)) - rust-lang#98561 (Fix spelling in SAFETY comment) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting some errors while testing this, but I'm pretty sure that was unrelated to my changes.
Closes #98436
I also added an
unknownescape-hatch because I didn't find corresponding issues for every// known-bug.The syntax also ended up being
// known-bug:, because ofset_name_value_directive.