Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable] Prepare 1.62.0 stable release #98571

Merged
merged 2 commits into from
Jun 27, 2022
Merged

[stable] Prepare 1.62.0 stable release #98571

merged 2 commits into from
Jun 27, 2022

Conversation

pietroalbini
Copy link
Member

This PR backports the latest release note changes from master, and prepares the stable artifacts.

r? @ghost

@pietroalbini
Copy link
Member Author

@bors r+ p=1000 rollup=never

@bors
Copy link
Contributor

bors commented Jun 27, 2022

📌 Commit 9b230ea has been approved by pietroalbini

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 27, 2022
@bors
Copy link
Contributor

bors commented Jun 27, 2022

⌛ Testing commit 9b230ea with merge 666de998a2eec970f22370310f9b3f35938f7d7f...

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
.......... (60/64)
...       (64/64)


/checkout/src/test/rustdoc-gui/search-filter.goml search-filter... FAILED
[ERROR] (line 6) TimeoutError: waiting for selector "#titles" failed: timeout 30000ms exceeded: for command `wait-for: "#titles"`
Build completed unsuccessfully in 0:00:42

@bors
Copy link
Contributor

bors commented Jun 27, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 27, 2022
@pietroalbini
Copy link
Member Author

@bors retry spurious

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2022
@bors
Copy link
Contributor

bors commented Jun 27, 2022

⌛ Testing commit 9b230ea with merge a8314ef...

wwylele
wwylele reviewed Jun 27, 2022
View reviewed changes
RELEASES.md
Libraries
---------

- [Move `CStr` to libcore, and `CString` to liballoc][94079]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding of #98314, this is still unstable. Should this be in the stable release note?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like an oversight. If you'd like to file a PR against the master branch, that'd be great!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #98597

@bors
Copy link
Contributor

bors commented Jun 27, 2022

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing a8314ef to stable...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 27, 2022
@bors bors merged commit a8314ef into rust-lang:stable Jun 27, 2022
@rustbot rustbot added this to the 1.62.0 milestone Jun 27, 2022
@pietroalbini pietroalbini deleted the pa-1.62.0-stable branch June 27, 2022 18:22
wwylele added a commit to wwylele/rust that referenced this pull request Jun 27, 2022
@wwylele
Remove unstable CStr/CString change from 1.62 release note
f5a38d1 
(Discovered in rust-lang#98571 (comment))

The change to move CStr/CString to core/alloc is currently behind feature flags as stated in rust-lang#98314
@wwylele wwylele mentioned this pull request Jun 27, 2022
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 28, 2022
@Dylan-DPC
Rollup merge of rust-lang#98597 - wwylele:patch-1, r=Mark-Simulacrum
18c086f 
Remove unstable CStr/CString change from 1.62 release note

(Discovered in rust-lang#98571 (comment))

The change to move CStr/CString to core/alloc is currently behind feature flags as stated in rust-lang#98314
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 28, 2022
@Dylan-DPC
Rollup merge of rust-lang#98597 - wwylele:patch-1, r=Mark-Simulacrum
66b8060 
Remove unstable CStr/CString change from 1.62 release note

(Discovered in rust-lang#98571 (comment))

The change to move CStr/CString to core/alloc is currently behind feature flags as stated in rust-lang#98314
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

@wwylele wwylele wwylele left review comments

Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
6 participants
@pietroalbini @bors @rust-log-analyzer @wwylele @Mark-Simulacrum @rustbot