-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add risc-v based Android compile target #99005
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thomcc (or someone else) soon. Please see the contribution instructions for more information. |
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
|
This PR is generated with the changes under: |
To speed up the review process of this PR, you could directly add to your initial message the answers to the Tier 3 "Target tier policy". Example here #94872 (comment). As well as adding an entry in src/doc/rustc/src/platform-support, example here https://github.com/rust-lang/rust/pull/94872/files#diff-d320f0b01f351d17f71e524691dca8850180c49d04913eef532d6cfc6469a09e |
This comment has been minimized.
This comment has been minimized.
202ddcf
to
a01c62c
Compare
The stdlib changes are minimal and appear fine, but most of this needs compiler-team signoff. r? rust-lang/compiler |
Signed-off-by: Chen Guoyin <[email protected]> Signed-off-by: Mao Han <[email protected]>
a01c62c
to
11d96d9
Compare
This is the rustc side changes to support risc-v based Android target(riscv64gc_linux_android).
I volunteer to maintain this target.
This riscv64gc section is consistent with riscv64gc_unknown_linux_gnu.rs and the linux_android section is the same as other android target
I think the target name does not introduce any ambiguity.
It's using open source tools only.
All of the additional code will use Apache-2.0.
Understood.
There are no new dependencies/features required.
It's using open source tools only.
There are no such terms present.
This paragraph does not appear to be directed at me.
This paragraph does not appear to be directed at me.
It has same standard libraries support as other android target.
Building is described in platform support doc, testing is done with an android emulator .
Understood.
Understood.
I believe I didn't break any other target.
I think there are no such problems in this PR.
Signed-off-by: Chen Guoyin [email protected]
Signed-off-by: Mao Han [email protected]