Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve getting-started guide #792

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Jul 11, 2020

  • Clean up wording
  • Suggest build --stage 1 src/libstd, which doesn't recompile rustc
    twice unnecessarily
  • Fix rustdoc globs which only work on Linux
  • Add suggestion for build --stage 0 src/libstd
  • Suggest -j1 for very slow builds
  • Suggesting letting CI run tests when using a slow machine

Note that most of this will become outdated when/if rust-lang/compiler-team#326 is implemented.

- Clean up wording
- Suggest `build --stage 1 src/libstd`, which doesn't recompile rustc
twice unnecessarily
- Fix rustdoc globs which only work on Linux
- Add suggestion for `build --stage 0 src/libstd`
- Suggest `-j1` for very slow builds
- Suggesting letting CI run tests when using a slow machine
@jyn514
Copy link
Member Author

jyn514 commented Jul 11, 2020

Also the '~45 minutes to an hour' thing was very iffy. @mark-i-m how long do stage1 builds normally take you on your laptop?

Copy link
Member

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mark-i-m mark-i-m merged commit f196779 into rust-lang:master Jul 14, 2020
@jyn514 jyn514 deleted the getting-started branch July 14, 2020 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants