-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
triage for this week. #1385
triage for this week. #1385
Conversation
encode the start and end points in the url as suggested by nnethercote, thanks!
And only now i realized that weekly triages don't contain info about which one metric it talks about (instruction counts currently. No max-rss changes info?). |
That was my oversight; I should have specifically noted that I was talking about instruction counts in my report. i think I looked briefly at max-rss and didn’t notice anything worth noting. But I’ll double check when I’m at a proper laptop instead of a phone. |
https://perf.rust-lang.org/?start=2022-07-25&end=2022-08-03&kind=percentfromfirst&stat=max-rss max-rss actually was improved as well; summary says by 1-2% or so (it's a pretty noisy metric). Given that, I don't think its worth trying to change the summary text at this point. cycles, instruction-counts, and max-rss all saw positive trajectories over the past week, from what I can see. |
I'm talking about units used in tables. For example, when we see rust-lang/rust#95026 (comment): tables annotated types by it's titles: instruction counts, max-rss, cycles. |
No description provided.