Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not vertically align list items in case the tactic is Horizontal #3093

Merged
merged 2 commits into from
Oct 14, 2018

Conversation

scampi
Copy link
Contributor

@scampi scampi commented Oct 12, 2018

part of #2633

This does not close the issue because the use case described in #2633 (comment) is not fixed, but the rest seems fine.

@scampi
Copy link
Contributor Author

scampi commented Oct 12, 2018

The integration test of stdsimd fails with an issue similar to #3008.

 /// ```rust
-/// # #![cfg_attr(not(dox), feature(cfg_target_feature, target_feature, stdsimd))]
+/// # #![cfg_attr(not(dox), feature(cfg_target_feature, target_feature,
+/// stdsimd))]
 /// ...
 /// ```
  • a first run of rustfmt reformats the attribute, leaving stdsimd on a new line but uncommented.
  • rustfmt tries to format that code block again but fails and exit with 101 because of that new line.

@nrc nrc merged commit 2f8c1fe into rust-lang:master Oct 14, 2018
@nrc
Copy link
Member

nrc commented Oct 14, 2018

Thanks!

@scampi scampi deleted the issue2633 branch October 15, 2018 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants