Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rustc-ap-* crates to 407.0.0 #3447

Merged
merged 9 commits into from
Mar 14, 2019
Merged

Conversation

topecongiro
Copy link
Contributor

This PR updates rustc-ap-* crates to 407.0.0 and resolve breaking changes.

cc @Xanewok and @kngwyu.

Update `rustc-ap-*` crates to 407.0.0.
Invalid clippy attributes have become a hard parser error.
Libsyntax has improved a lot since these code were written. Remove old hacks and
simplify the logic.
This change is necessary due to the recent change in the rustc parser that the
following attribute has become a hard parser error:

```rust
struct Foo;
```

cc rust-lang/rust#57367.
Copy link
Contributor

@scampi scampi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tests/source/doc-attrib.rs Show resolved Hide resolved
src/items.rs Show resolved Hide resolved
@topecongiro topecongiro merged commit ce5cccc into rust-lang:master Mar 14, 2019
@topecongiro topecongiro deleted the submod branch March 14, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants