fixed => () to => {} #4226
Merged
fixed => () to => {} #4226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topecongiro
approved these changes
Jun 2, 2020
pickfire
reviewed
Jun 2, 2020
| @@ -15,7 +15,7 @@ fn main() { | |||
| let y = match (try { | |||
| foo()? | |||
| }) { | |||
| _ => (), | |||
| _ => {}, | |||
There was a problem hiding this comment.
Why does this have the , at the end while the others and others does not?
pickfire
reviewed
Jun 2, 2020
| @@ -15,7 +15,7 @@ fn main() { | |||
| // Test case where first chain element isn't a path, but is shorter than | |||
| // the size of a tab. | |||
| x() | |||
| .y(|| match cond() { true => (), false => () }); | |||
| .y(|| match cond() { true => {}, false => {}, }); | |||
pickfire
reviewed
Jun 2, 2020
| @@ -16,7 +16,7 @@ fn main() { | |||
| // Test case where first chain element isn't a path, but is shorter than | |||
| // the size of a tab. | |||
| x() | |||
| .y(|| match cond() { true => (), false => () }); | |||
| .y(|| match cond() { true => {} false => {} }); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, for making a new pull request but there were alot of new changes in the past day or so to the structure and I didn't want to go through merge conflicts. This fixes issue #4065. It also leaves it so that match_trailing_comma will still have a comma if left to true (this was the change requested on the previous pr)