Rename wasm32-wasi to wasm32-wasi-preview1
#1417
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon. |
yoshuawuyts
changed the title
wasm32-wasi to wasm32-wasi-preview1wasm32-wasi to wasm32-wasi-preview1
|
I believe CI is failing because rust-lang/rust#110596 has not been merged yet. |
Yes. I wonder if you want to also add preview2 in the same PR since I assume the current code should be tested (and works) with it as well. |
|
LGTM, just ping me once rust-lang/rust#110596 makes it into a nightly and I'll merge this. |
7 tasks
3 tasks
3 tasks
alexcrichton
added a commit
to alexcrichton/stdarch
that referenced
this pull request
Mar 5, 2024
This commit is a replacement for rust-lang#1417 now that rust-lang/rust#12046 has landed. While I was here I went ahead and updated the Wasmtime used in CI and adapted its command line as well.
|
I've posted a replacement for this at #1546 in light of the "new plan" |
Amanieu
pushed a commit
that referenced
this pull request
Mar 5, 2024
This commit is a replacement for #1417 now that rust-lang/rust#12046 has landed. While I was here I went ahead and updated the Wasmtime used in CI and adapted its command line as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements rust-lang/compiler-team#607. Sibling to rust-lang/rust#110596 and rust-lang/rustc-dev-guide#1678.
This PR renames the
wasm32-wasitarget towasm32-wasi-preview1, in accordance to the accepted compiler team MCP. I'm not sure what the right ordering is wrt merging this PR? Does this need to wait on rust-lang/rust#110596 being merged first?