Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add windows group #347

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Add windows group #347

merged 1 commit into from
Jun 9, 2020

Conversation

spastorino
Copy link
Member

@nikomatsakis
Copy link
Contributor

See rust-lang/compiler-team#293 for context =)

@nikomatsakis
Copy link
Contributor

@spastorino CI is unhappy?

@spastorino spastorino force-pushed the add-wg-windows branch 2 times, most recently from 74f3cc0 to b80eb24 Compare May 28, 2020 18:43
@spastorino spastorino changed the title Add wg-windows Add windows group May 28, 2020
@spastorino spastorino mentioned this pull request May 28, 2020
Closed
9 tasks
@spastorino spastorino force-pushed the add-wg-windows branch 2 times, most recently from dccb5cc to 7b40d87 Compare June 4, 2020 14:26
rylev
rylev reviewed Jun 4, 2020
View reviewed changes
people/sivadeilra.toml Outdated
@@ -0,0 +1,3 @@
name = 'sivadeilra'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "Arlie Davis".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it manually. cargo run add-person gets the name from Github.

@nikomatsakis nikomatsakis merged commit 2b02c07 into rust-lang:master Jun 9, 2020
@tmandry tmandry mentioned this pull request Jan 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylev rylev rylev left review comments

@retep998 retep998 retep998 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spastorino @nikomatsakis @retep998 @rylev